lwIP - A Lightweight TCP/IP stack - Tasks: task #15072, SNMP support for notifications and...
You are not allowed to post comments on this tracker with your current authentication level.
task #15072: SNMP support for notifications and informs (v2c)
Submitter: | Ognjen Bjelica <ognjenbjelica> | ||
Submitted: | Tue 23 Oct 2018 01:11:19 PM UTC | ||
Category: | None | Should Start On: | Tue 23 Oct 2018 12:00:00 AM UTC |
Should be Finished on: | Tue 23 Oct 2018 12:00:00 AM UTC | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Percent Complete: | 0% |
Open/Closed: | Closed | Planned Release: | None |
Effort: | 0.00 |
Jump to the original submission
Wed 07 Nov 2018 08:06:25 PM UTC, comment #16: |
Dirk Ziegelmeier <dziegel> |
Fri 26 Oct 2018 06:14:58 PM UTC, comment #15: I cleaned up your patch, but I do not have the time to test it at the moment. I add it here as a basis for further discussion.
|
Dirk Ziegelmeier <dziegel> |
Thu 25 Oct 2018 06:43:17 AM UTC, comment #14: The struct snmp_msg_trap should remain in snmp_traps.c - it is not a good idea to export an internal structure just to transport "isInform" and "snmpVersion". I think the API needs to be changed. There should be similar functions as for traps, e.g.
|
Dirk Ziegelmeier <dziegel> |
Wed 24 Oct 2018 05:38:09 PM UTC, comment #13: In snmp.h, you declare a function
|
Dirk Ziegelmeier <dziegel> |
Wed 24 Oct 2018 02:23:30 PM UTC, comment #12: On a second look, you could add a goto to the cleanup end, or you could try to skip snmp_prepare_outbound_frame() for informs and then just return?
|
Simon Goldschmidt <goldsimon> |
Wed 24 Oct 2018 01:21:33 PM UTC, comment #11: I still don't know why you need ERR_SKIP. If you never test for it, you can just return any other error? If I don't understand it, how can I propose anything? |
Simon Goldschmidt <goldsimon> |
Wed 24 Oct 2018 01:04:59 PM UTC, comment #10: Please let me know your proposal for ERR_SKIP.
|
Ognjen Bjelica <ognjenbjelica> |
Wed 24 Oct 2018 12:38:47 PM UTC, comment #9: Sorry I didn't see you latest response in time. Now I understand your point regarding err.h. I agree, it will be removed. I will send you new version of patch tomorrow.
|
Ognjen Bjelica <ognjenbjelica> |
Wed 24 Oct 2018 12:27:25 PM UTC, comment #8: - You cannot define new errors in err.h just to implement SNMP informs (plus, why do you add 'ERR_SKIP' if you never test for it?).
|
Simon Goldschmidt <goldsimon> |
Wed 24 Oct 2018 12:19:26 PM UTC, comment #7: You are right regarding ignoring results. While porting our changes from 2.0.3 to 2.1.0 I have failed to realize that BUILD_EXEC will affect our modifications as well.
|
Ognjen Bjelica <ognjenbjelica> |
Wed 24 Oct 2018 11:56:47 AM UTC, comment #6: Ok, now the functions using BUILD_EXEC() have return values, but you ignore them. As a result, e.g. snmp_send_msg() will send out a broken frame if something goes wrong in snmp_trap_header_enc() or snmp_trap_header_enc_pdu().
|
Dirk Ziegelmeier <dziegel> |
Wed 24 Oct 2018 11:46:21 AM UTC, comment #5: Please try new patch. I wasn't able to find exactly the same settings as ones for gcc in the compiler we are using, but I've found similar ones. I think that all the issues should be fixed now. If you detect any more warnings please let me know. |
Ognjen Bjelica <ognjenbjelica> |
Wed 24 Oct 2018 08:26:21 AM UTC, comment #4: OK, I will do that. Currently we are using proprietary compiler. |
Ognjen Bjelica <ognjenbjelica> |
Wed 24 Oct 2018 08:11:49 AM UTC, comment #3: Please check you patch again and read/check all the issues I reported. Most of them are not fixed!
|
Dirk Ziegelmeier <dziegel> |
Wed 24 Oct 2018 07:36:11 AM UTC, comment #2: Sorry it seems that I didn't exported right commit. It has been fixed in later commits. I will post new patch soon. Sorry for inconvenience. |
Ognjen Bjelica <ognjenbjelica> |
Wed 24 Oct 2018 07:24:46 AM UTC, comment #1: The patch contains changes in err.h which seem to be unused, e.g. typedef ... err_status_t and #define ERR_IS_FATAL()
|
Dirk Ziegelmeier <dziegel> |
Tue 23 Oct 2018 01:11:19 PM UTC, original submission:
While we were using SNMP app, one of the requirements was to support sending traps in v1 and v2c. Since original app wasn’t providing these functionalities, we have implemented them as a patch. Now SNMP app has support for sending traps, notifications and informs. For informs we have added callback, so main app can have feedback. |
Ognjen Bjelica <ognjenbjelica> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-11-07 | dziegel | Open/Closed | Open | Closed | |
2018-11-07 | dziegel | Status | None | Done | |
2018-10-26 | dziegel | Attached File | - | Added snmp_informs.patch, #45309 | |
2018-10-24 | ognjenbjelica | Attached File | - | Added 0005-Fixes-for-SNMP-app-by-Softhouse-ComAp - New-features.patch, #45281 | |
2018-10-24 | ognjenbjelica | Attached File | - | Added 0004-Fixes-for-SNMP-app-by-Softhouse-ComAp - New-features.patch, #45280 | |
2018-10-24 | ognjenbjelica | Attached File | - | Added 0003-Fixes-for-SNMP-app-by-Softhouse-ComAp - New-features.patch, #45279 | |
2018-10-24 | ognjenbjelica | Attached File | - | Added 0002-Fixes-for-SNMP-app-by-Softhouse-ComAp - New-features.patch, #45273 | |
2018-10-23 | ognjenbjelica | Attached File | - | Added 0001-Fixes-for-SNMP-app-by-Softhouse-ComAp - New-features.patch, #45269 | |
Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-caa5.
Corresponding source code
Pushed your patch. If you implement a statemachine for informs, please open a new patch entry.
Thanks for providing your implementation!