lwIP - A Lightweight TCP/IP stack - Bugs: bug #18782, the default PBUF_POOL_BUFSIZE...
You are not allowed to post comments on this tracker with your current authentication level.
bug #18782: the default PBUF_POOL_BUFSIZE value should be changed
Submitter: | dupengbo <dupengbo> | ||
Submitted: | Mon 15 Jan 2007 03:37:41 AM UTC | ||
Category: | IPv4 | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | kieranm |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Wed 28 Mar 2007 12:27:59 PM UTC, comment #9: |
Kieran Mansley <kieranm> |
Mon 26 Mar 2007 10:46:23 AM UTC, comment #8: OK. Reopening to include the PBUF_LINK_HLEN. That had occured to me as a good solution, but wasn't sure if that value would have been specified by this point and didn't have time to investigate further. Will do so now. |
Kieran Mansley <kieranm> |
Fri 23 Mar 2007 07:58:24 AM UTC, comment #7: It is better if PBUF_LINK_HLEN is accounted.
|
dupengbo <dupengbo> |
Fri 23 Mar 2007 04:25:35 AM UTC, comment #6: We sort of should be putting ethernet specific settings here, or rather we should account for it by using PBUF_LINK_HLEN. That's a user-settable option and reflects the intention of what should be reserved, so we should use that.
|
Jonathan Larmour <jifl> |
Thu 22 Mar 2007 01:41:54 PM UTC, comment #5: You're probably right, but (i) should we be putting ethernet specific settings here? and (ii) the default is so small that most people will want to change it.
|
Kieran Mansley <kieranm> |
Thu 22 Mar 2007 01:32:27 PM UTC, comment #4: Shouldn't the PBUF_POOL_BUFSIZE include ethernet header, also? I did not look into the code, just thinking: If I send TCP_MSS data, I have to put a TCP, IP and ETH header in front of the data or else I will have to allocate a new pbuf for that. |
Simon Goldschmidt <goldsimon> |
Wed 21 Mar 2007 01:07:04 PM UTC, comment #3: Done, closing fixed. The real issue with this is that we need PBUF_POOL_BUFSIZE to be TCP_MSS+40 for most efficient operation. This change fixes it for the default case. |
Kieran Mansley <kieranm> |
Mon 26 Feb 2007 01:41:27 PM UTC, comment #2: Makes sense to me FWIW. |
Jonathan Larmour <jifl> |
Mon 26 Feb 2007 12:59:51 PM UTC, comment #1: I think this is a good suggestion. Any objections to this change going in? |
Kieran Mansley <kieranm> |
Mon 15 Jan 2007 03:37:41 AM UTC, original submission:
for example:
|
dupengbo <dupengbo> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-03-28 | kieranm | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2007-03-26 | kieranm | Status | Fixed | In Progress | |
Open/Closed | Closed | Open | |||
2007-03-21 | kieranm | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2007-02-26 | kieranm | Assigned to | None | kieranm | |
2007-01-15 | dupengbo | Carbon-Copy | Removed -email is unavailable- | - | |
2007-01-15 | dupengbo | Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-f8d8.
Corresponding source code
Now done, closing.