lwIP - A Lightweight TCP/IP stack - Bugs: bug #19345, tcpip_apimsg+api_msg_post problem
You are not allowed to post comments on this tracker with your current authentication level.
bug #19345: tcpip_apimsg+api_msg_post problem
Submitter: | Frédéric Bernon <fbernon> | ||
Submitted: | Mon 19 Mar 2007 04:53:45 PM UTC | ||
Category: | None | Severity: | 4 - Important |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | fbernon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Wed 21 Mar 2007 05:09:34 PM UTC, comment #8: |
Frédéric Bernon <fbernon> |
Wed 21 Mar 2007 05:09:06 PM UTC, comment #7:
I don't understand this question (in this context) ? But no, I don't meet this condition. Of course, I will tell you if I see something like that... |
Frédéric Bernon <fbernon> |
Wed 21 Mar 2007 11:55:16 AM UTC, comment #6: Seems OK to me. |
Kieran Mansley <kieranm> |
Tue 20 Mar 2007 07:44:50 PM UTC, comment #5: I join a patch to solve the problem, and to improve reliability (and code is more simple).
|
Frédéric Bernon <fbernon> |
Tue 20 Mar 2007 09:55:35 AM UTC, comment #4: Other solution (if someone read it?):
|
Frédéric Bernon <fbernon> |
Tue 20 Mar 2007 08:27:21 AM UTC, comment #3: api_msg_post() is only used in api_lib.c. Each call is the same sequence:
|
Frédéric Bernon <fbernon> |
Mon 19 Mar 2007 08:37:04 PM UTC, comment #2: First step is done. Before change api_lib.c, is there any comments?
|
Frédéric Bernon <fbernon> |
Mon 19 Mar 2007 05:09:31 PM UTC, comment #1: Sounds like a good idea to me. |
Kieran Mansley <kieranm> |
Mon 19 Mar 2007 04:53:45 PM UTC, original submission:
tcpip_apimsg & api_msg_post functions don't have any return type. So, if we got any memp_malloc error, api_msg_post's caller doesn't know that the message is not sent. And in api_lib.c, we always wait an answer with a sys_mbox_fetch(conn->mbox, NULL); But tcpip_thread will never answers, because he never got the message.
|
Frédéric Bernon <fbernon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-03-21 | fbernon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2007-03-20 | fbernon | Attached File | - | Added tcpip_apimsg.patch, #12223 |
Powered by Savane 3.13-02a9.
Corresponding source code
Commited with:
void
api_msg_input(struct api_msg *msg)
{ struct api_msg_msg msg_copy;
msg_copy=msg->msg;
decode[msg->type](&msg_copy);
}