lwIP - A Lightweight TCP/IP stack - Bugs: bug #19432, netbuf_ref doesn't check...
You are not allowed to post comments on this tracker with your current authentication level.
bug #19432: netbuf_ref doesn't check pbuf_alloc result
Submitter: | Frédéric Bernon <fbernon> | ||
Submitted: | Wed 28 Mar 2007 09:10:34 AM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | Crash Error | Status: | Fixed |
Privacy: | Public | Assigned to: | fbernon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Wed 28 Mar 2007 01:59:41 PM UTC, comment #7: |
Kieran Mansley <kieranm> |
Wed 28 Mar 2007 01:38:45 PM UTC, comment #6: Ok to set "buf->ptr = NULL;" only if (buf->p == NULL), it's better.
|
Frédéric Bernon <fbernon> |
Wed 28 Mar 2007 01:11:24 PM UTC, comment #5: Ahh, OK. You're setting buf->ptr = NULL in case the alloc fails, to make sure it is a sensible value. In that case it should read:
|
Kieran Mansley <kieranm> |
Wed 28 Mar 2007 01:06:01 PM UTC, comment #4:
|
Frédéric Bernon <fbernon> |
Wed 28 Mar 2007 12:30:55 PM UTC, comment #3: Should the new line:
|
Kieran Mansley <kieranm> |
Wed 28 Mar 2007 10:18:32 AM UTC, comment #2: Sorry, forget api.h
|
Frédéric Bernon <fbernon> |
Wed 28 Mar 2007 10:13:28 AM UTC, comment #1: Patch file I propose to commit... |
Frédéric Bernon <fbernon> |
Wed 28 Mar 2007 09:10:34 AM UTC, original submission:
In netbuf_ref, pbuf_alloc result is not tested. A check and a return value can be add...
|
Frédéric Bernon <fbernon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-03-28 | fbernon | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2007-03-28 | fbernon | Attached File | - | Added netbuf_ref.patch, #12320 | |
2007-03-28 | fbernon | Attached File | - | Added netbuf_ref.patch, #12319 |
Powered by Savane 3.13-02a9.
Corresponding source code
You are quite right, sorry.
Yes, go ahead as you describe.