buglwIP - A Lightweight TCP/IP stack - Bugs: bug #19937, ICMP assumes p_buf has space for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #19937: ICMP assumes p_buf has space for ethernet header

Submitted by:  Matthias Weisser <mod42>
Submitted on:  Wed 23 May 2007 08:43:30 AM UTC  
 
Category:  IPv4 Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  Simon Goldschmidt <goldsimon>
Open/Closed:  Closed Planned Release:  None
lwIP version:  None

( Jump to the original submission)

Fri 15 Jun 2007 06:58:08 AM UTC, comment #9: 

Closing this as fixed (again).

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 14 Jun 2007 05:41:21 PM UTC, comment #8: 

Checked in the change, works for me now (1000-byte pings, 128-byte pbuf pool size).

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 14 Jun 2007 06:50:14 AM UTC, comment #7: 

There seems to be an error here:
on lwip-users, Matthias Weisser wrote:

> I get an assertion in the new ICMP code (adding space in front of
> the packet for ethernet header) when the incoming ICMP packet
> occupies more than on pbuf.
>
> Assertion "cmp_input: copying to new pbuf failed " failed at line
> 117 in /pathtosource/lwip/core/ipv4/icmp.c


I'm working on that this weekend.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 13 Jun 2007 10:42:16 AM UTC, comment #6: 

OK, closing it as fixed.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 12 Jun 2007 06:25:03 AM UTC, comment #5: 

Today I merged the current CVS version into my port and verified that the change from Simon is working. So from my point of view this bug can be closed.

PS:
Sorry for the delay, I was on vacations.

Matthias Weisser <mod42>
Sat 09 Jun 2007 04:17:35 PM UTC, comment #4: 

> It's include in my test build since Monday, and I don't have see any problems, but I don't test big pings


Big pings? The problem came from allocating a pbuf on receiving that didn't get the ethernet header included (e.g. first look into receive fifo and if it's an IP packet only copy the IP part into the pbuf). That way, when reusing the pbuf to send the echo reply, the pbuf didn't have space for the ethernet header at its front.

I did test it, but I wanted to hear a comment from the original poster...

Maybe we can close it as I have tested it to be OK...

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sat 09 Jun 2007 12:05:16 PM UTC, comment #3: 

It's include in my test build since Monday, and I don't have see any problems, but I don't test big pings (and my buffers are large), and it is a "black box" checking...

Frédéric Bernon <fbernon>
Project Member
Mon 04 Jun 2007 02:31:45 PM UTC, comment #2: 

Thanks Simon - this is probably best tested by the original reporter of the problem. 

Kieran Mansley <kieranm>
Project Member
Sun 03 Jun 2007 11:07:49 AM UTC, comment #1: 

I've checked in a change to icmp_input: on sending an echo response, p is chacked if it's big enough. If not, a new pbuf (PBUF_RAM) is allocated and used instead.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 23 May 2007 08:43:30 AM UTC, original submission:  

The ICMP implementation assumes that there is enough space at the front of a pbuf to store an ethernet header. If this is not the case etharp_output fails when trying to add the ethernet header.

Matthias Weisser <mod42>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by fbernon (Posted a comment)
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by mod42 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-06-15 goldsimon StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2007-06-14 goldsimon StatusIn Progress => Ready For Test
    2007-06-14 goldsimon StatusFixed => In Progress
        Open/ClosedClosed => Open
    2007-06-13 goldsimon StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2007-06-03 goldsimon StatusNone => Ready For Test
        Assigned toNone => goldsimon
    2007-05-24 tom_evans Carbon-Copy- => Added tom_evans
    2007-05-23 mod42 Carbon-Copy- => Added matthias.weisser@graf-syteco.de

    Back to the top


    Powered by Savane 3.5