lwIP - A Lightweight TCP/IP stack - Bugs: bug #20288, event_callback is called from...
You are not allowed to post comments on this tracker with your current authentication level.
bug #20288: event_callback is called from multiple threads without locking
Submitter: | Simon Goldschmidt <goldsimon> | ||
Submitted: | Thu 28 Jun 2007 10:52:47 AM UTC | ||
Category: | sockets/netconn | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Wont Fix |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Wed 25 Jul 2007 06:06:12 PM UTC, comment #3: |
Simon Goldschmidt <goldsimon> |
Fri 13 Jul 2007 05:02:10 PM UTC, comment #2: Hmm, as long as we only look at the socket layer (which is the only code really using the callbacks inside the stack), it seems I didn't read the code properly: it is protected right now, only this is done with a semaphore in sockets.c:event_callback().
|
Simon Goldschmidt <goldsimon> |
Sat 30 Jun 2007 03:19:41 PM UTC, comment #1: There is also a call in netconn_accept. For netconn_recv, for the TCP part, I think it's easy to move the callback inside the do_recv. For the RAW/UDP part, there is no such call (do_recv), so, add one will add a thread-context switch, and it's not a good idea.
|
Frédéric Bernon <fbernon> |
Thu 28 Jun 2007 10:52:47 AM UTC, original submission:
conn->callback is called from api_msg.c in the core-receive-callbacks (recv_raw/recv_udp/recv_tcp) but also from netconn_recv, when data was received by the application. This is definitively not thread-safe.
|
Simon Goldschmidt <goldsimon> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-07-25 | goldsimon | Status | None | Wont Fix | |
Open/Closed | Open | Closed | |||
2007-07-13 | kieranm | Planned Release | 1.3.0 |
Powered by Savane 3.13-02a9.
Corresponding source code
I don't plan to change this for the 'old' socket layer, so I'm closing this.