lwIP - A Lightweight TCP/IP stack - Bugs: bug #20346, IPv4 broadcasts ?
You are not allowed to post comments on this tracker with your current authentication level.
bug #20346: IPv4 broadcasts ?
Submitter: | S. Ali Tokmen <alitokmen> | ||
Submitted: | Wed 04 Jul 2007 03:53:25 PM UTC | ||
Category: | IPv4 | Severity: | 3 - Normal |
Item Group: | Feature Request | Status: | Invalid |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Fri 06 Jul 2007 06:53:58 AM UTC, comment #7: |
S. Ali Tokmen <alitokmen> |
Thu 05 Jul 2007 09:43:36 PM UTC, comment #6:
|
Frédéric Bernon <fbernon> |
Thu 05 Jul 2007 08:20:05 PM UTC, comment #5: After evaluate the fix discussed in previous post, I think this bug can be fixed in different place, lwip code or ADI code. There is another Bug #17200 seems to address the same issue. But we confirmed that fix for bug #17200 did not fix the broadcast problem. The fix mentioned here does fix the problem. However I am just curious why this problem cannot be fixed in lwip code. Any particular reason?
|
Zhenwei Chu <blackfin> |
Thu 05 Jul 2007 08:47:06 AM UTC, comment #4: Ok, seen with S. Ali Tokmen...
|
Frédéric Bernon <fbernon> |
Thu 05 Jul 2007 07:34:27 AM UTC, comment #3: Yes, you're right, if they don't set NETIF_FLAG_BROADCAST, so ip_addr_isbroadcast will return NULL. In this case, the loop in line 256 (CVS HEAD)...
|
Frédéric Bernon <fbernon> |
Thu 05 Jul 2007 07:22:05 AM UTC, comment #2: Hello, Frédéric
|
S. Ali Tokmen <alitokmen> |
Wed 04 Jul 2007 09:45:14 PM UTC, comment #1: Hi Ali,
|
Frédéric Bernon <fbernon> |
Wed 04 Jul 2007 03:53:25 PM UTC, original submission:
In the current implementation, IPv4 ignores broadcast packets. This results in the non-usability of services depending on broadcast (for example, NetBIOS name lookup).
|
S. Ali Tokmen <alitokmen> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-07-05 | fbernon | Status | None | Invalid | |
Open/Closed | Open | Closed |
Powered by Savane 3.13-caa5.
Corresponding source code
Hello Zhenwei,
As Frédéric mentioned in his reply, the issue is on Analog Devices' side:
- During initialization, lwIP calls the external low_level_init function. That function does the initialization of the Ethernet hardware, and is of course hardware specific.
- That function takes as argument a pointer to a struct netif, which describes the Ethernet device to lwIP.
- By default, netif's flags are all set to false. As a result, IP broadcast, which is a feature requiring that flag to be set, is disabled by default.
- In the code example in lwIP's source code, the NETIF_FLAG_BROADCAST flag is being set. On the other hand, for some reason, Analog Devices didn't set this flag in their Ethernet driver.
Analog Devices has been made aware of the issue, and they've told me this problem will be fixed in their IDE's next major release (VisualDSP++ 5.0). This release should be out in late summer 2007.
Regards;
S. Ali Tokmen
http://ali.tokmen.com/