lwIP - A Lightweight TCP/IP stack - Bugs: bug #20900, Potential crash error problem with...
You are not allowed to post comments on this tracker with your current authentication level.
bug #20900: Potential crash error problem with netconn_peer & netconn_addr
Submitter: | Frédéric Bernon <fbernon> | ||
Submitted: | Sat 25 Aug 2007 01:39:35 PM UTC | ||
Category: | None | Severity: | 4 - Important |
Item Group: | Crash Error | Status: | Fixed |
Privacy: | Public | Assigned to: | fbernon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Mon 12 Nov 2007 10:42:46 PM UTC, comment #20: |
Frédéric Bernon <fbernon> |
Mon 12 Nov 2007 06:20:40 PM UTC, comment #19:
|
Frédéric Bernon <fbernon> |
Mon 12 Nov 2007 11:14:15 AM UTC, comment #18: I prefer (2) as well.
|
Jonathan Larmour <jifl> |
Sun 11 Nov 2007 07:37:59 PM UTC, comment #17: I'd prefer the second solution. I think it's more simple if the same function can be used for all types of netconn. Also I don't think it's a real disadvantage that a task switch is needed for UDP and RAW because getpeeraddr is not needed that often (in most cases, it is returned with the receive call). |
Simon Goldschmidt <goldsimon> |
Sun 11 Nov 2007 06:53:26 PM UTC, comment #16: Ok, I propose two solutions (I join two files, but not in diff format, but in a text file with part changes, it was more readable):
|
Frédéric Bernon <fbernon> |
Fri 09 Nov 2007 01:49:44 PM UTC, comment #15: Ok, I will try time this weekend to propose a patch to fix it... |
Frédéric Bernon <fbernon> |
Fri 09 Nov 2007 01:00:18 PM UTC, comment #14: Any update on the status of this? This is one I might be prepared to drop from 1.3.0, but if you're nearly done on it already we can go ahead. I'll leave it in 1.3.0 for now. |
Kieran Mansley <kieranm> |
Sun 07 Oct 2007 05:34:11 PM UTC, comment #13: Change of netconn_addr parameters list is done. In the CHANGELOG, you can read :
|
Frédéric Bernon <fbernon> |
Fri 05 Oct 2007 03:32:34 PM UTC, comment #12: I'm setting the severety to '4 - important' to reflect the fact that it's planned for 1.3.0 (that way, all bugs planned for 1.3.0 are >= 4) |
Simon Goldschmidt <goldsimon> |
Fri 05 Oct 2007 03:30:18 PM UTC, comment #11: No, just the time! I was thinking to do that this weekend, and spend a little time to comment and document since this is a API breakage. |
Frédéric Bernon <fbernon> |
Fri 05 Oct 2007 03:28:28 PM UTC, comment #10: Frédéric, as this is planned for 1.3.0, is there anything holding us back from making the change? |
Simon Goldschmidt <goldsimon> |
Tue 18 Sep 2007 12:57:39 PM UTC, comment #9: As I understand it the problem is that we return a pointer to an address that can change under the feet of the caller. You're suggesting to improve this by copying the address and returning as a value rather than a pointer into the pcb structure.
|
Kieran Mansley <kieranm> |
Fri 07 Sep 2007 11:51:54 PM UTC, comment #8: PUSH ! Comment #3 thoughts ? |
Frédéric Bernon <fbernon> |
Fri 31 Aug 2007 03:32:57 PM UTC, comment #7: I'll try and look at this next week. Sorry for the delay. |
Kieran Mansley <kieranm> |
Fri 31 Aug 2007 03:24:31 PM UTC, comment #6: Since the design of netconn_addr can cause stack crash, I'm in flavor the change it, even if it break one function of the API. Kieran, thoughts?
|
Frédéric Bernon <fbernon> |
Fri 31 Aug 2007 03:21:09 PM UTC, comment #5: (from IRC Chat #lwip)
|
Frédéric Bernon <fbernon> |
Thu 30 Aug 2007 05:58:25 PM UTC, comment #4: Sorry, some * have disappear in the bugtracker. So, look api.h to see the prototype. The idea should be to remove one indirection for "addr" parameter.
|
Frédéric Bernon <fbernon> |
Thu 30 Aug 2007 05:53:55 PM UTC, comment #3: I got a first partial patch, but I see another problem with the netconn_addr prototype:
|
Frédéric Bernon <fbernon> |
Mon 27 Aug 2007 10:10:37 AM UTC, comment #2: Ok, it's check in. Now, I prepare a patch fo do_getpeername & do_getaddrname...
|
Frédéric Bernon <fbernon> |
Sun 26 Aug 2007 02:22:17 PM UTC, comment #1: No objects for this first part of the patch? |
Frédéric Bernon <fbernon> |
Sat 25 Aug 2007 01:39:35 PM UTC, original submission:
I think there is a potential crash error problem with netconn_peer & netconn_addr
|
Frédéric Bernon <fbernon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-11-13 | fbernon | Status | Works For Me | Fixed | |
Open/Closed | Open | Closed | |||
2007-11-12 | fbernon | Status | In Progress | Works For Me | |
2007-11-11 | fbernon | Attached File | - | Added getaddr.txt, #14358 | |
Attached File | - | Added gettcpaddr.txt, #14359 | |||
2007-10-07 | fbernon | Status | None | In Progress | |
2007-10-05 | goldsimon | Severity | 3 - Normal | 4 - Important | |
2007-08-26 | fbernon | Attached File | - | Added NETCONN_LISTEN.patch, #13804 |
Powered by Savane 3.13-02a9.
Corresponding source code
Ok, it's check in. If there is no objections, I will close it tomorrow...