lwIP - A Lightweight TCP/IP stack - Bugs: bug #21846, LwIP doesn't appear to perform any...
You are not allowed to post comments on this tracker with your current authentication level.
bug #21846: LwIP doesn't appear to perform any IP Source Address Filtering
Submitter: | Tom Evans <tom_evans> | ||
Submitted: | Wed 19 Dec 2007 01:32:31 AM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | fbernon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Thu 03 Jan 2008 05:50:01 PM UTC, comment #9: |
Jonathan Larmour <jifl> |
Thu 03 Jan 2008 05:13:48 PM UTC, comment #8: I have a preference for check_ip_src (without _valid), but change it if you prefer.
|
Frédéric Bernon <fbernon> |
Thu 03 Jan 2008 02:36:18 PM UTC, comment #7: I've been away so only just looking at this. In comment #5 are you asking if people think ipsrcchk is a good variable name? If so, then I think check_ip_src_valid would be clearer. If you agree, I'll change (so small I'd normally just do it to save effort, but I don't want to tread on toes).
|
Jonathan Larmour <jifl> |
Sun 30 Dec 2007 01:10:16 AM UTC, comment #6: Check in. Please, reopen if something is wrong...
|
Frédéric Bernon <fbernon> |
Mon 24 Dec 2007 06:16:26 PM UTC, comment #5: ipsrcchk = have to check "ip source". But when I read ip_src_valid, I think to "the ip source is valid".
|
Frédéric Bernon <fbernon> |
Sun 23 Dec 2007 04:13:04 PM UTC, comment #4: From looking at the patch file (can't test at the moment), it looks fine. Although I would change the variable name to something more meaningful like ip_src_valid. |
Simon Goldschmidt <goldsimon> |
Sun 23 Dec 2007 12:07:47 PM UTC, comment #3: Add an exception in the patch for dhcp packets. |
Frédéric Bernon <fbernon> |
Sun 23 Dec 2007 11:44:52 AM UTC, comment #2: Sorry, there is an extra pbuf_free in the patch. I attach a new one. |
Frédéric Bernon <fbernon> |
Sat 22 Dec 2007 10:57:40 PM UTC, comment #1: Seems a valid comment. Proposed patch file is attached. Any objections?
|
Frédéric Bernon <fbernon> |
Wed 19 Dec 2007 01:32:31 AM UTC, original submission:
RFC1122 (October 1989):
|
Tom Evans <tom_evans> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-12-30 | fbernon | Item Group | None | Faulty Behaviour | |
Status | None | Fixed | |||
Assigned to | None | fbernon | |||
Open/Closed | Open | Closed | |||
Planned Release | 1.3.0 | ||||
2007-12-23 | fbernon | Attached File | - | Added ip.c.patch, #14690 | |
2007-12-23 | fbernon | Attached File | - | Added ip.c.patch, #14689 | |
2007-12-22 | fbernon | Attached File | - | Added ip.c.patch, #14685 | |
2007-12-19 | tom_evans | Carbon-Copy | - | Added tom_evans |
Powered by Savane 3.13-f8d8.
Corresponding source code
Done as check_ip_src.