lwIP - A Lightweight TCP/IP stack - Bugs: bug #22249, TCP MSS set to 0 into TCP option
You are not allowed to post comments on this tracker with your current authentication level.
bug #22249: TCP MSS set to 0 into TCP option
Submitter: | Marc Chaland <chaland> | ||
Submitted: | Thu 07 Feb 2008 01:26:43 PM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | Crash Error | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Wed 26 Mar 2008 11:58:39 AM UTC, comment #6: |
Simon Goldschmidt <goldsimon> |
Wed 26 Mar 2008 08:21:59 AM UTC, comment #5: Why not simply test for 0 division? If the remote side wants it to be smaller than 28, why not? Checking for TCP_MSS_MIN would be unnecessary code bloat, in my opinion. |
Simon Goldschmidt <goldsimon> |
Tue 04 Mar 2008 01:10:21 PM UTC, comment #4: Lets leave this till after 1.3.0 |
Kieran Mansley <kieranm> |
Fri 08 Feb 2008 04:00:11 PM UTC, comment #3: About the RFC, I saw this which provides some context, and indicates that the real minimum can be lower: http://www.ietf.org/mail-archive/web/tsvwg/current/msg04483.html
|
Jonathan Larmour <jifl> |
Fri 08 Feb 2008 03:34:40 PM UTC, comment #2: A malicious client may crash easily IP stack by sending a null TCP MSS option. One similar bug has already been fixed :
|
Marc Chaland <chaland> |
Fri 08 Feb 2008 10:00:48 AM UTC, comment #1: Definetly MSS is not 0,
|
Oleg Tyshev <olegreen> |
Thu 07 Feb 2008 01:26:43 PM UTC, original submission:
If client tries to connect with a TCP MSS option set to 0, division by 0 exception occurs. Server side should limit minimum size for MSS to 536 into tcp_parseopt() function.
|
Marc Chaland <chaland> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2008-03-26 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2008-03-04 | kieranm | Planned Release | 1.3.1 |
Powered by Savane 3.13-02a9.
Corresponding source code
I have included a test for mss != 0 (in that case, TCP_MSS is used).
I think this fix is good enough and TCP_MSS_MIN is not needed.