mldonkey, a multi-networks file-sharing client - Bugs: bug #23518, Verify chunks causes bad...
You are not allowed to post comments on this tracker with your current authentication level.
bug #23518: Verify chunks causes bad statistics on file
Submitter: | Renato Alves <rjalves> | ||
Submitted: | Sat 07 Jun 2008 04:04:34 PM UTC | ||
Category: | Core | Severity: | 3 - Normal |
Item Group: | Program malfunction | Status: | None |
Assigned to: | None | Open/Closed: | Open |
Release: | None | Release: | 2.9.5 |
Operating System: | Linux | Binaries Origin: | Gentoo ebuild |
CPU type: | Intel x86 |
Sun 25 Apr 2010 08:58:40 PM UTC, comment #3: |
ygrek <ygrek>![]() |
Sat 10 Apr 2010 04:40:12 PM UTC, comment #2: Basically you are reverting patch #6401 here which incompletely fixed another bug.
|
spiralvoice <spiralvoice>![]() |
Sat 10 Apr 2010 01:35:10 PM UTC, comment #1: Fix attached.
|
ygrek <ygrek>![]() |
Sat 07 Jun 2008 04:04:34 PM UTC, original submission:
Added a ed2k file that downloaded for a couple of days.
|
Renato Alves <rjalves> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follows 1 latest change.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2010-04-10 | ygrek | Attached File | - | ![]() |
Added verify_chunks.diff, #20181 |
I think patch #6401 is wrong anyway and should be reverted (and better solution found for that problem), it counts the data as downloaded when it is not the case - i.e. it already resides on disk, maybe it was a partial download from another client. The only way to count the data as downloaded is when it is read from the socket or else such strange results will occur. Counting of downloaded data shouldn't be done in swarmer - do you agree? Rather we should have two counters - downloaded and available bytes. First is counted somewhere near network reading, second is tracked by swarmer.
For the bug numbers, agreed, though I personally would have done it another way round (bugs as primary entities and patches linked to bugs (not bugs promoted to patches)).