bugmldonkey, a multi-networks file-sharing client - Bugs: bug #23518, Verify chunks causes bad...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #23518: Verify chunks causes bad statistics on file

Submitted by:  Renato Alves <rjalves>
Submitted on:  Sat 07 Jun 2008 04:04:34 PM UTC  
 
Category: CoreSeverity: 3 - Normal
Item Group: Program malfunctionStatus: None
Assigned to: NoneOpen/Closed: Open
Release: 2.9.5Release: None
Operating System: LinuxBinaries Origin: Gentoo ebuild
CPU type: Intel x86

Sun 25 Apr 2010 08:58:40 PM UTC, comment #3:

I think patch #6401 is wrong anyway and should be reverted (and better solution found for that problem), it counts the data as downloaded when it is not the case - i.e. it already resides on disk, maybe it was a partial download from another client. The only way to count the data as downloaded is when it is read from the socket or else such strange results will occur. Counting of downloaded data shouldn't be done in swarmer - do you agree? Rather we should have two counters - downloaded and available bytes. First is counted somewhere near network reading, second is tracked by swarmer.

For the bug numbers, agreed, though I personally would have done it another way round (bugs as primary entities and patches linked to bugs (not bugs promoted to patches)).

ygrek <ygrek>
Project Member
Sat 10 Apr 2010 04:40:12 PM UTC, comment #2:

Basically you are reverting patch #6401 here which incompletely fixed another bug.

Regarding the bug numbers, I think it is not really necessary because you can see the former bug number of a patch in the patch history, like here:
http://savannah.nongnu.org/patch/index.php?6961#history

spiralvoice <spiralvoice>
Project Administrator
Sat 10 Apr 2010 01:35:10 PM UTC, comment #1:

Fix attached.
BTW I'd suggest adding to changelog entries bug numbers that were closed by the patch.

(file #20181)

ygrek <ygrek>
Project Member
Sat 07 Jun 2008 04:04:34 PM UTC, original submission:

Added a ed2k file that downloaded for a couple of days.

Using the web interface:

After some download time and a couple of sessions I clicked the filename and then verify chunks to make sure everything was going ok.

Doing this caused the file statistics to be displayed incorrectly.
One of the files displayed information like the following:

size DLed % ETA
26.1M 35.4M 135.6 -1:-40

This didn't affect the file itself since eventually the download ended without problems nor corruption.

Meanwhile I tried the same with other files and in all of them the same happened.

This problem only affects the current session. Restarting mldonkey causes the files to display the correct info again.

Renato Alves <rjalves>

 

Attached Files
file #20181:  verify_chunks.diff added by ygrek (575B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by spiralvoice (Posted a comment)
  • -unavailable- added by ygrek (Updated the item)
  • -unavailable- added by rjalves (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 10 Apr 2010 01:35:10 PM UTCygrekAttached File-=>Added verify_chunks.diff, #20181

    Back to the top


    Powered by Savane 3.1-cleanup