lwIP - A Lightweight TCP/IP stack - Bugs: bug #26236, TCP options (timestamp) don't work...
You are not allowed to post comments on this tracker with your current authentication level.
bug #26236: TCP options (timestamp) don't work with no-copy-tcpwrite
Submitter: | Simon Goldschmidt <goldsimon> | ||
Submitted: | Sun 19 Apr 2009 12:30:34 PM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | CVS Head |
Mon 20 Apr 2009 07:54:03 AM UTC, comment #2: |
Kieran Mansley <kieranm> |
Sun 19 Apr 2009 12:45:34 PM UTC, comment #1: Kieran, I've checked in a change that deallocates the space reserved for options and only concatenates segments with the same flags. I think this fixes it, but I'd be happy to know your thoughts about it before closing this entry as fixed (since the timestamp/option code is from you). |
Simon Goldschmidt <goldsimon> |
Sun 19 Apr 2009 12:30:34 PM UTC, original submission:
When calling tcp_write (on a pcb with the TF_TIMESTAMP flag turned on) without the COPY flag, it allocates 2 pbufs (RAM for headers + options, ROM for data).
|
Simon Goldschmidt <goldsimon> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-04-20 | kieranm | Open/Closed | Open | Closed | |
2009-04-20 | kieranm | Status | Ready For Test | Fixed | |
2009-04-19 | goldsimon | Status | In Progress | Ready For Test |
Powered by Savane 3.13-02a9.
Corresponding source code
Thanks for this (and all the other fixes to the timestamp code that you've made this week). From a quick glance at the code it looks good to me, and what you say makes sense. I'll try and find some time to test it, but I'm happy to resolve this fixed in the mean time.