buglwIP - A Lightweight TCP/IP stack - Bugs: bug #26407, Initialization

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #26407: Initialization

Submitted by:  Rikke Ottesen <ro03>
Submitted on:  Thu 30 Apr 2009 11:05:13 AM UTC  
 
Category:  IPv4 Severity:  3 - Normal
Item Group:  Change Request Status:  Invalid
Privacy:  Public Assigned to:  Simon Goldschmidt <goldsimon>
Open/Closed:  Closed Planned Release:  None
lwIP version:  1.3.0

Thu 30 Apr 2009 11:31:01 AM UTC, comment #2: 

OK fair enough.

Cheers
Rikke

Rikke Ottesen <ro03>
Thu 30 Apr 2009 11:23:06 AM UTC, comment #1: 

> Could you please initialize those?


Initiailize local variables although we don't need it? I'm afraid we won't do that as

a) we have previously discussed about that and came to the solution to remove initialization where it isn't needed
b) it would generate additional code that isn't needed and
c) there are some tools/compilers that would warn about an unnecessary initialization which I think would be correct to warn about

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 30 Apr 2009 11:05:13 AM UTC, original submission:  

The category does not only apply to IPv4 but this is more in general.

This is only a request, because I use a tool called Purify to find memory leaks an uinitialized memory.

There is a lot of code where the variables is'nt initialized in the different functions.
Ex.

ip.c file

ip_input(struct pbuf p, struct netif inp)
{
  struct ip_hdr *iphdr;
  struct netif *netif;
  u16_t iphdr_hlen;
  u16_t iphdr_len;

...

Could you please initialize those?

Cheers
Rikke

Rikke Ottesen <ro03>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by ro03 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-04-30 goldsimon StatusNone => Invalid
        Assigned toNone => goldsimon
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5