lwIP - A Lightweight TCP/IP stack - Bugs: bug #26649, TCP fails when TCP_MSS >...
You are not allowed to post comments on this tracker with your current authentication level.
bug #26649: TCP fails when TCP_MSS > TCP_SND_BUF
Submitter: | Robert Sprowson <sprow> | ||
Submitted: | Sat 23 May 2009 06:24:35 PM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | 1.3.0 |
Sun 23 Aug 2009 01:03:36 PM UTC, comment #3: |
Simon Goldschmidt <goldsimon> |
Tue 02 Jun 2009 11:02:17 AM UTC, comment #2: There should really be no relation between TCP_SND_QUEUELEN and TCP_MSS, but they are defined to have that dependency because (i) we assumed that TCP_MSS < TCP_SND_BUF and (ii) it makes sure that the send queue is big enough to get some performance out of the stack.
|
Kieran Mansley <kieranm> |
Sat 23 May 2009 08:34:55 PM UTC, comment #1: I'm not the expert on this options here and maybe we should wait for Kieran to return and give it a thought, but I'd say a sanity check should do: TCP_SND_BUF is a limitation introduced by lwIP and I don't see a point using an MSS larger than we can support, anyway... |
Simon Goldschmidt <goldsimon> |
Sat 23 May 2009 06:24:35 PM UTC, original submission:
I'm assuming it is valid to have TCP_MSS > TCP_SND_BUF, if not a sanity check in "core/init.c" might be worthwhile.
|
Robert Sprowson <sprow> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-08-23 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2009-06-02 | kieranm | Planned Release | 1.4.0 |
Powered by Savane 3.13-02a9.
Corresponding source code
Actually, that was a bug introduced in 1.3.0: the parenthesis were included there and were simply set wrong.
I've also added a check in init.c that TCP_SND_BUF is at least 2*TCP_MSS (necessary for nagle).