lwIP - A Lightweight TCP/IP stack - Bugs: bug #27034, Invalid ASSERT in pbuf_alloc()
You are not allowed to post comments on this tracker with your current authentication level.
bug #27034: Invalid ASSERT in pbuf_alloc()
Submitter: | Iordan Neshev <iordan_neshev> | ||
Submitted: | Wed 15 Jul 2009 12:45:31 PM UTC | ||
Category: | pbufs | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | CVS Head |
Jump to the original submission
Mon 27 Jul 2009 03:18:11 PM UTC, comment #8: |
Simon Goldschmidt <goldsimon> |
Thu 16 Jul 2009 07:50:20 AM UTC, comment #7: No, because they're also asking for space to be reserved for headers (the first argument to pbuf_alloc), so the resulting length won't be zero. It's only when called as pbuf_alloc(PBUF_RAW, 0, ...) that it's a problem I think. |
Kieran Mansley <kieranm> |
Thu 16 Jul 2009 07:09:29 AM UTC, comment #6:
|
Iordan Neshev <iordan_neshev> |
Thu 16 Jul 2009 05:50:49 AM UTC, comment #5: As said on lwip-devel, I'd just change the assert for releasing 1.3.1 and think about the PPP code after the release.
|
Simon Goldschmidt <goldsimon> |
Wed 15 Jul 2009 04:27:32 PM UTC, comment #4: Hm, if it really only checks "PBUF_POOL_BUFSIZE must be bigger than MEM_ALIGNMENT", then we'd better move the check into init.c so that it isn't executed always.
|
Simon Goldschmidt <goldsimon> |
Wed 15 Jul 2009 03:15:00 PM UTC, comment #3: Thanks for the extra information.
|
Kieran Mansley <kieranm> |
Wed 15 Jul 2009 02:57:45 PM UTC, comment #2:
|
Iordan Neshev <iordan_neshev> |
Wed 15 Jul 2009 02:42:54 PM UTC, comment #1: Just to ensure I understand this properly: the assertion incorrectly fires when you try to allocate a pbuf with zero length? Is there any other requirement to trigger the incorrect assertion?
|
Kieran Mansley <kieranm> |
Wed 15 Jul 2009 12:45:31 PM UTC, original submission:
In pbuf.c:
|
Iordan Neshev <iordan_neshev> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-07-27 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2009-07-15 | kieranm | Planned Release | 1.3.1 |
Powered by Savane 3.13-bb6a.
Corresponding source code
Fixed by using the assert suggested in the initial post to prevent breaking PPP.