lwIP - A Lightweight TCP/IP stack - Bugs: bug #27079, Yet another leak in PPP
You are not allowed to post comments on this tracker with your current authentication level.
bug #27079: Yet another leak in PPP
Submitter: | Iordan Neshev <iordan_neshev> | ||
Submitted: | Wed 22 Jul 2009 03:46:45 PM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | None | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | CVS Head |
Sun 06 Dec 2009 11:20:46 AM UTC, comment #4: |
Simon Goldschmidt <goldsimon> |
Thu 15 Oct 2009 06:47:55 PM UTC, comment #3: We really do need a developer caring about PPP or these bugs will never be closed... |
Simon Goldschmidt <goldsimon> |
Sun 23 Aug 2009 05:47:49 PM UTC, comment #2: Hmm, you're right that it is never deallocated, but since I cannot test it, too, inserting a mem_free somewhere seems kind of risky.
|
Simon Goldschmidt <goldsimon> |
Thu 20 Aug 2009 02:12:40 PM UTC, comment #1: I'd be happy for this to be fixed, but really need someone who can verify it. Any volunteers? |
Kieran Mansley <kieranm> |
Wed 22 Jul 2009 03:46:45 PM UTC, original submission:
In ppp.c, err_t pppInit(void):
|
Iordan Neshev <iordan_neshev> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-12-06 | goldsimon | Open/Closed | Open | Closed | |
Assigned to | None | goldsimon | |||
Status | Need Info | Fixed | |||
2009-10-15 | goldsimon | Status | None | Need Info |
Powered by Savane 3.13-f8d8.
Corresponding source code
Although this isn't a real bug, strictly spoken (it's an init function and lwIP doesn't provide a counterpart for that), I've fixed the bug by allocating outpacket_buf statically.
This is what ucip (the source of our ppp code) does and what we did up to lwIP 1.2.0. I really don't know why that has been changed in the first place... (introduced when adding PPPoE support in ppp.c 1.14) - the code is even smaller with static allocation.
Marc: if you read this and disagree, please let me know!