lwIP - A Lightweight TCP/IP stack - Bugs: bug #27390, Source IP check in ip_input()...
You are not allowed to post comments on this tracker with your current authentication level.
bug #27390: Source IP check in ip_input() causes it to drop valid DHCP packets
Submitter: | Mandeep Sandhu <mandeepsandhu> | ||
Submitted: | Mon 07 Sep 2009 07:42:10 AM UTC | ||
Category: | IPv4 | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | 1.3.0 |
Fri 16 Oct 2009 12:39:48 PM UTC, comment #3: |
Simon Goldschmidt <goldsimon> |
Fri 16 Oct 2009 06:03:47 AM UTC, comment #2: The part that resets check_ip_src does so only if we haven't found a suitable interface. This would happen when we're running as a DHCP client and haven't configured the interface yet. But, in my case I was running a DHCP server and already had the interface configured. So, the netif on which the packet was received is selected. This causes the reset (of check_ip_src) part to be skipped. I think we should do a check for DHCP server port (68) as well. Something like:
|
Mandeep Sandhu <mandeepsandhu> |
Thu 15 Oct 2009 04:21:24 PM UTC, comment #1: I also think it should be ok to allow 0.0.0.0 as src IP. But maybe it is better to include the necessary check in the part that resets check_ip_src.
|
Simon Goldschmidt <goldsimon> |
Mon 07 Sep 2009 07:42:10 AM UTC, original submission:
I'm running my ECOS application with lwIP 1.3.1. The app is a small DHCP server (with limited functionality).
|
Mandeep Sandhu <mandeepsandhu> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-10-16 | goldsimon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2009-10-15 | goldsimon | Status | None | In Progress | |
Assigned to | None | goldsimon | |||
2009-10-15 | kieranm | Planned Release | 1.3.2 |
Powered by Savane 3.13-02a9.
Corresponding source code
Fixed by allowing 0.0.0.0 as source address when LWIP_DHCP is 1.