buglwIP - A Lightweight TCP/IP stack - Bugs: bug #28732, struct in_addr conflicts with OS...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #28732: struct in_addr conflicts with OS type

Submitter:  Simon Goldschmidt <goldsimon>
Submitted:  Mon 25 Jan 2010 09:31:31 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  CVS Head

Fri 29 Jan 2010 08:27:28 AM UTC, comment #1: 

Cleanly separate the portability file inet.h and its contents from the stack: moved htonX-functions to def.h (and the new def.c - they are not ipv4 dependent),let inet.h depend on ip_addr.h and not the other way round.

-> now struct in_addr is only define when explicitly including one of the compatibility api header files, not when including the raw api files.

Simon Goldschmidt <goldsimon>
Group administrator
Mon 25 Jan 2010 09:31:31 AM UTC, original submission:  

struct in_addr should not be defined in inet.h or htons/htonl and address defines (none/loopback/any/broadcast) should be moved to another file.

The reason is that inet.h is included in many files to get htons etc. but that defines struct in_addr which might be defined by the OS already (e.g. if compiling the win32 or unix port).

Simon Goldschmidt <goldsimon>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-01-29 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code