lwIP - A Lightweight TCP/IP stack - Bugs: bug #28775, select/event_callback: only check...
You are not allowed to post comments on this tracker with your current authentication level.
bug #28775: select/event_callback: only check select_cb_list on change
Submitter: | Simon Goldschmidt <goldsimon> | ||
Submitted: | Sat 30 Jan 2010 03:17:56 PM UTC | ||
Category: | sockets/netconn | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | CVS Head |
Jump to the original submission
Sun 07 Mar 2010 06:46:08 PM UTC, comment #6: |
Simon Goldschmidt <goldsimon> |
Mon 08 Feb 2010 05:29:31 PM UTC, comment #5:
|
Simon Goldschmidt <goldsimon> |
Sun 07 Feb 2010 10:42:59 PM UTC, comment #4: Maybe it's a bit late, but I'm not in favor of using SYS_LIGHTWEIGHT_PROT for the socket array.
|
Stephane Lesage <slesage> |
Sun 07 Feb 2010 12:51:42 AM UTC, comment #3: You're right the wake-up test can be moved before the loop.
|
Stephane Lesage <slesage> |
Mon 01 Feb 2010 03:51:38 PM UTC, comment #2: That would have been covered by the initial check (lwip_selscan() is called before actually waiting).
|
Simon Goldschmidt <goldsimon> |
Mon 01 Feb 2010 09:53:29 AM UTC, comment #1: We have to support the case where someone calls select on a socket that has already had notification of a change in state. |
Kieran Mansley <kieranm> |
Sat 30 Jan 2010 03:17:56 PM UTC, original submission:
Currently, every call to API_EVENT/event_callback leads to scanning the select_cb_list for waiting selects.
|
Simon Goldschmidt <goldsimon> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2010-03-07 | goldsimon | Item Group | None | Change Request | |
Status | None | Fixed | |||
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
Planned Release | 1.4.0 |
Powered by Savane 3.13-caa5.
Corresponding source code
Checked in:
- using SYS_LIGHTWEIGHT_PROT to protect the socket code (carefully chosen to not disable interrupts for too long)
- added a counter to each socket that tells event_callback if anyone is waiting using select, which speeds up receiving when noone is waiting
Tested with the tests-functions in contrib/apps/socket_examples.c.