buglwIP - A Lightweight TCP/IP stack - Bugs: bug #30129, struct _ip_addr should be struct...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30129: struct _ip_addr should be struct ip_addr

Submitter:  Bill Auerbach <billauerbach>
Submitted:  Mon 14 Jun 2010 05:49:50 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  CVS Head

Mon 14 Jun 2010 07:53:25 PM UTC, comment #1: 

I agree. While developing the changes was easier with the underscore, leaving it away makes updating to 1.4.0 easier.

Simon Goldschmidt <goldsimon>
Group administrator
Mon 14 Jun 2010 05:49:50 PM UTC, original submission:  

Adding the leading underscore breaks a lot of existing code unnecessarily.  This struct and typedef can be:

struct ip_addr {
  u32_t addr;
};

and

typedef struct ip_addr ip_addr_t;

As the typedef and struct are synonymous it can be as above without breaking code but allowing the cleaner typedef to also be used in application code and as it is now in lwIP 1.4

Bill Auerbach <billauerbach>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by billauerbach (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-06-14 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code