buglwIP - A Lightweight TCP/IP stack - Bugs: bug #30447, tcp.c:tcp_bind() - suspicious...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30447: tcp.c:tcp_bind() - suspicious nested #if

Submitter:  Iordan Neshev <iordan_neshev>
Submitted:  Wed 14 Jul 2010 04:38:36 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  CVS Head

Wed 28 Jul 2010 04:45:35 PM UTC, comment #1: 

Seems like I made a mistake when merging versions before checking in... Thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 14 Jul 2010 04:38:36 PM UTC, original submission:  

tcp.c, in function tcp_bind() on line 411 there is:

#if SO_REUSE
  /* Unless the REUSEADDR flag is set,
     we have to check the pcbs in TIME-WAIT state, also.
     We do not dump TIME_WAIT pcb's; they can still be matched by incoming
     packets using both local and remote IP addresses and ports to distinguish.
   */
#if SO_REUSE
  if ((pcb->so_options & SOF_REUSEADDR) != 0) {
    max_pcb_list = NUM_TCP_PCB_LISTS_NO_TIME_WAIT;
  }
#endif /* SO_REUSE */
#endif /* SO_REUSE */

There is one #if SO_REUSE nested. Seems like something is either missing or not needed.


Iordan Neshev <iordan_neshev>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by iordan_neshev (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-28 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code