I enclose a patch that enables building davfs2-1.4.7 under uclibc-0.9.30.3.

It was cross-compiled with gcc-4.3.3 and tested on a ARM NAS running a free alternative firmware (Alt-F) under linux-2.6.35.14 with busybox-1.20.2.

Notes:

-cache.c:check_cache_dir(): if the user home directory has the set-group-ID bit set then the cache is created with the wrong permissions, try to chmod() if first before failing

-webdav.c:ssl_verify(): as rpmatch() doesn't exists, use fgets() and a direct comparison

-umount_dav.c:main(): as canonicalize_file_name() doesn't exists, use realpath()

-mount_dav.h: as "fstab.h" doesn't exists, define _PATH_FSTAB

-mount_dav.c:
o don't include fstab.h, as it doesn't exists
o as argz_create() doesn't exists, include it from gnulib
o check_dir(): some system() command strings are not quoted, making command such as 'cp' fail when the path has spaces on it (such as "/home/Joao Cardoso" -- nothing forbids it)
o check_fstab():
 o as  getfsfile() doesn't exists, add get_fstab_mountpoint() that uses getmntent()
 o disable user/users/mopts check, as busybox mount command does not pass then to the mount helpers; anyway, the mount helpers are only called if user or users are present in the matched fstab entry
  o check_mountpoint(): as canonicalize_file_name() doesn't exists, use realpath()

Thanks,
Joao

(file #27511)

Something seems off with gnulib (I'm using a version which is just about a week old).
gnulib creates the static library in ./gl/libgnu.a. This is however not used when doing the final linking; which thus davfs2 fails to compile (see log below).
My patch added _LDADD=libgnu.a, so that works. If I add ../gl/libgnu.a to the below line everything links correctly.
eg in src/Makefile.am

mount_davfs_LDADD = $(LIBINTL) $(LIBICONV) ../gl/libgnu.a
umount_davfs_LDADD = $(LIBINTL) ../gl/libgnu.a

I find it pretty strange since the instructions only talked about adding LIBINTL and LIBICONV, although guides on the internet talk about adding libgnu.a yourself.

I have a few warnings:

dav_coda.c: In function 'dav_coda_loop':
dav_coda.c:165:5: warning: implicit declaration of function 'malloc'
dav_coda.c:165:11: warning: incompatible implicit declaration of built-in function 'malloc'
dav_fuse.c: In function 'dav_fuse_loop':
dav_fuse.c:165:5: warning: implicit declaration of function 'malloc'
dav_fuse.c:165:11: warning: incompatible implicit declaration of built-in function 'malloc'
cache.o: In function `clean_tree':
cache.c:(.text+0x26c4): warning: the use of OBSOLESCENT `utime' is discouraged, use `utimes'

linking fails:

gcc -Wall -O2 -pipe -I/ffp/include/neon -D_LARGEFILE64_SOURCE -DNE_LFS  -Wl,-rpath -Wl,/ffp/lib -o mount.davfs cache.o dav_coda.o dav_fuse.o kernel_interface.o mount_davfs.o webdav.o -lintl -liconv -Wl,-rpath -Wl,/ffp/lib -L/ffp/lib -lneon -lz -L/ffp/lib -lssl -lcrypto -ldl -L/ffp/lib -lproxy -lexpat
cache.o: In function `clean_tree':
cache.c:(.text+0x26c4): warning: the use of OBSOLESCENT `utime' is discouraged, use `utimes'
/ffp/lib/libcrypto.so: warning: gethostbyname is obsolescent, use getnameinfo() instead.
mount_davfs.o: In function `read_secrets':
mount_davfs.c:(.text+0x1204): undefined reference to `rpl_canonicalize_file_name'
mount_davfs.c:(.text+0x1654): undefined reference to `rpl_canonicalize_file_name'
mount_davfs.o: In function `read_config':
mount_davfs.c:(.text+0x1924): undefined reference to `rpl_canonicalize_file_name'
mount_davfs.o: In function `main':
mount_davfs.c:(.text+0x2af0): undefined reference to `rpl_canonicalize_file_name'
mount_davfs.c:(.text+0x3d48): undefined reference to `rpl_canonicalize_file_name'
webdav.o: In function `ssl_verify':
webdav.c:(.text+0x8d4): undefined reference to `rpmatch'
collect2: ld returned 1 exit status
make[2]: *** [mount.davfs] Error 1
make[2]: Leaving directory `/mnt/md1/build/davfs2/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/mnt/md1/build/davfs2'
make: *** [all] Error 2

Hello Tomi,

thanks for the patches. I'm glad there is again somebody who cares about portability issues with uClibc.

But we should avoid double efforts. I have not done a new release of the source package for a long time. But meanwhile I did some bug fixes - including portability issues - and also started using gnulib. But as I made no new release (there was always some 'small' issue I wanted to deal with first, and there still are some) you did not see them. They are only in the CVS-sources. Please always use the CVS-sources for patches.

Some hints how davfs2 sources are organized:
In the CVS sources I try to only store real source files. As far as possible I will not store any files that are created or copied by tools, like the Gnu auto-tools or gnulib.
When you fetch the latest sources from CVS you will need the full set of auto-tools, gettext and now Gnulib too. Please see config/INSTALL.davfs for details. First thing is to run ./bootstrap which will call gnulib-tool, gettext and the auto tools. These tools will copy a lot of files (e.g. .m4 macros) into the source tree and also create the script 'configure'.

The source tarball will contain everthing everthing you need to build the package with './configure; make; make install' without the need to have gnulib, and the auto tools.

Patches that are intended for the main tree of davfs2 should only patch files that are in the source files from CVS. Changes to other files will be overwritten by './bootstrap'.

I think I have already fixed these protability issues in the CVS-sources:
- rpmatch (using gnulib)
- argz (by not using it any more)
- fstab (by using mtab functions like in your patch)
BTW: Sorry. I did not remember having fixed the fstab issue when we discussed your problems with fstab. I think that patch that removes the fstab-checks is no longer necessary when using the CVS-sources.

log-writer:
I could not yet test your patch on my system. But it looks good to me and I think I will apply it. The error is probably not in uClibc but it was my error ta take every call of log_writer for a seperate log entry. So checking for the new line character looks like the proper thing to do. I will have to test it with 'debug httpbody' because I am not sure that these messages will always end with '\n'.

It would be nice if you could test the latest sources from CVS so we can fix the remaining issues with uClib.
To avoid parallel development, her is what I'm working on:
- at the moment (moment = probably next weekend) I am working on bug #33644
- before the next release I also want to fix that 'servercert' mess.

Cheers
Werner

Hello Collin.

"On which path can we do discuss about the changes?"
Let's discuss it here.

"Rights management is not mature"
Please explain what problems you see.

"seteuid should replaced with setresuid"
According to the Gnu-Libc-Documentation setreuid is intended for use on systems that lack the _POSIX_SAVED_IDS feature. To enhance portability I will change the code to test for this feature and use setreuid if it is missing.

"cache directory should work with davfs-user / at a directory with davfsuser-file-permissions"
It does.
There are two cases:
- mounting done by root
davfs2 runs as user davfs2. The cache is owned by this user.
- mounting done by an unpriveleged user
davfs2 runs as the mounting user. All resources are treated as private resources owned by this user.
What do you think is wrong with this?

"blocked file systems when files are transferred to server"
Please see https://savannah.nongnu.org/support/?107593

"if I set PREFIX with configure, not all paths in the project or link-creations are right"
Which ones? Please note that there is an exception for /sbin. davfs2 is a mount helper and must be found by mount which only searches /sbin. Please also take notice of the configure script option 'ssbindir'.

Cheers
Werner

Though I use the GNU autotools to keep davfs2 portable the only system I am familiar with is GNU/Linux. And it is the only system davfs2 has been tested on.
This report is a good chance to start resolving some portability issues. That's what I intend to do:

setfsent, getfsfile and endfsent:
These functions are replaced by setmntent, getmntent and endmntent.

argz_create, argz_stringify, canonicalize_file_name, rpmatch:
I don't want to miss the functionality of these functions. So I am going to use Gnulib to add replacement functions. As I never used Gnulib before this will need some time.

iconvert:
Most systems davfs2 is running on use utf-8 character encoding and iconvert will hardly ever be used. So I should add a configuration option to disable the use of iconvert. Not sure whether to additionally add iconvert from Gnulib.

Werner