buglwIP - A Lightweight TCP/IP stack - Bugs: bug #34681, Limit ARP queue length by...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #34681: Limit ARP queue length by ARP_QUEUE_LEN (=3)

Submitter:  Amir Shalem <amirshalem>
Submitted:  Sat 29 Oct 2011 08:37:52 AM UTC
   
 
Category:  ARP Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  CVS Head

Sat 22 Feb 2014 08:39:47 PM UTC, comment #4: 

And also finally done, thanks for the patch.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 10 Nov 2011 04:34:22 PM UTC, comment #3: 

OK, that seems fair enough then, I'm happy to replicate what others do in this circumstance.

Kieran Mansley <kieranm>
Group Member
Tue 08 Nov 2011 06:01:11 AM UTC, comment #2: 

That's may be true, but the ARP layer is not IP.

After black box testing Windows & Linux, it seems both are dropping old packets in favor of new packets.
Which means that the newest TCP SYN packet will be sent, and not the oldest.

Amir Shalem <amirshalem>
Tue 01 Nov 2011 12:52:43 PM UTC, comment #1: 

This seems like a reasonable feature.

I'm just wondering if dropping old packets in favour of new ones is the right approach.  At most points in a stack new packets are dropped in favour of old ones.

Kieran Mansley <kieranm>
Group Member
Sat 29 Oct 2011 08:37:52 AM UTC, original submission:  

I propose to limit the ARP queue length, by ARP_QUEUE_LEN (defaults to 3).

This will make sure that if two IPs are unresolved, then the first one them won't be able to "steal" all the MEMP_ARP_QUEUE objects, by limiting both queues to ARP_QUEUE_LEN packets awaiting in each queue.

From what I understand & tested, this will shouldn't hurt any higher level (UDP, TCP, ICMP, applications, ...)

Patch included.

Amir Shalem

Amir Shalem <amirshalem>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #24237:  limit_arp_queue_length.patch added by amirshalem (2KiB - application/octet-stream - ARP_QUEUE_LEN patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by amirshalem (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-02-22 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2011-11-01 kieranm Planned Release 1.5.0
    2011-10-29 amirshalem Attached File- Added limit_arp_queue_length.patch, #24237

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code