buglwIP - A Lightweight TCP/IP stack - Bugs: bug #35809, PPP GetMask(): Compiler warning on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35809: PPP GetMask(): Compiler warning on big endian, possible bug on little endian system

Submitter:  Bostjan Meglic <bostjanm>
Submitted:  Mon 12 Mar 2012 03:23:23 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  Compiler Warning Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  1.4.0

Mon 12 Mar 2012 03:40:38 PM UTC, comment #2: 

Fixed in both branches (DEVEL-1_4_1 and master).

Simon Goldschmidt <goldsimon>
Group administrator
Mon 12 Mar 2012 03:34:35 PM UTC, comment #1: 

Next time you report a bug, please tell us where it is (you haven't provided that information anywhere but in the patch file).

Other than that, that's a real bug which is in there since ppp was initially added (in 2003).

Thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Mon 12 Mar 2012 03:23:23 PM UTC, original submission:  

I have BIG_ENDIAN system, so htonx()/ntohx() functions are empty.
But I still got a compiler warning about 'expression has no effect' on the following line:

htonl(addr);

Shouldn't that read as

addr = htonl(addr); ?


Bostjan Meglic <bostjanm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by bostjanm (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-03-12 goldsimon StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2012-03-12 goldsimon StatusNone In Progress
        Assigned toNone goldsimon
        Planned Release 1.4.1
        SummaryCompiler warning on big endian, possible bug on little endian system PPP GetMask(): Compiler warning on big endian, possible bug on little endian system
    2012-03-12 bostjanm Attached File- Added Store-computed-value-addr-back-to-the-variable.patch, #25334

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code