buglwIP - A Lightweight TCP/IP stack - Bugs: bug #35817, do_connect() invalidly signals...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35817: do_connect() invalidly signals op_completed for UDP/RAW with LWIP_TCPIP_CORE_LOCKING==1

Submitter:  hanhui <hanhui03>
Submitted:  Mon 12 Mar 2012 05:07:46 PM UTC
   
 
Category:  sockets/netconn Severity:  3 - Normal
Item Group:  Crash Error Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  CVS Head

Sun 25 Mar 2012 12:57:13 PM UTC, comment #4: 

Fixed in master (1.4.1 branch is not affected), thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Sun 25 Mar 2012 12:52:41 PM UTC, comment #3: 

Updated summary to tell something about the bug.

Simon Goldschmidt <goldsimon>
Group administrator
Tue 13 Mar 2012 05:57:57 PM UTC, comment #2: 

Great! I agree add a flag in msg struct.

hanhui <hanhui03>
Tue 13 Mar 2012 04:36:37 PM UTC, comment #1: 

This has been introduced since 1.4.1 was branched, so we don't need to fix it for that release.

It sounds like we need to make an equivalent change to do_connect so that it only calls op_completed when necessary.  Or have a flag in msg that indicates that this is needed.

Kieran Mansley <kieranm>
Group Member
Mon 12 Mar 2012 05:07:46 PM UTC, original submission:  

netconn_connect()
{
    if (tcp) {
        msg.function = do_connect;
        tcpip_apimsg(&msg);

    } else if (udp or raw) {
        TCPIP_APIMSG(...do_connect...);
    }
}

in core lock mode, tcpip_apimsg() need signal op_completed, but TCPIP_APIMSG() does not needed!

BUT:do_connect() always signal the op_completed! here is a BUG! that will cause a faulty behaviour!


hanhui <hanhui03>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by hanhui03 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-03-25 goldsimon Open/ClosedOpen Closed
    2012-03-25 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
    2012-03-25 goldsimon Summarynetconn_connect or do_connect() have a BIG bug!!! do_connect() invalidly signals op_completed for UDP/RAW with LWIP_TCPIP_CORE_LOCKING==1
    2012-03-13 kieranm Planned Release 1.5.0

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code