buglwIP - A Lightweight TCP/IP stack - Bugs: bug #36170, dhcp array access out of bounds.

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #36170: dhcp array access out of bounds.

Submitter:  zg <zg0>
Submitted:  Fri 13 Apr 2012 11:45:33 PM UTC
   
 
Category:  TCP Severity:  3 - Normal
Item Group:  Compiler Warning Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  1.4.0

Thu 03 May 2012 06:23:11 PM UTC, comment #1: 

Strictly speaking, you're correct. But it doesn't have an impact unless the global variable 'dhcp_rx_options_given' happens to be at the end of some memory segment and you are running on hardware that checks invalid access. I've fixed it, anyway, thanks for reporting!

Simon Goldschmidt <goldsimon>
Group administrator
Fri 13 Apr 2012 11:45:33 PM UTC, original submission:  

in dhcp.c:
while(dhcp_option_given(dhcp, DHCP_OPTION_IDX_DNS_SERVER + n) && (n < DNS_MAX_SERVERS)) {
bound check must be before access, isnt it?

zg <zg0>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by zg0 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-05-03 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code