buglwIP - A Lightweight TCP/IP stack - Bugs: bug #37549, Need to disable HISADDR check for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #37549: Need to disable HISADDR check for PPP

Submitter:  Mark Lakata <lakata>
Submitted:  Thu 11 Oct 2012 05:54:23 PM UTC
   
 
Category:  PPP Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  1.4.0

Thu 22 May 2014 07:43:15 PM UTC, comment #3: 

ppp-new branch merged in master

Sylvain Rochet <gradator>
Group Member
Thu 11 Oct 2012 06:13:54 PM UTC, comment #2: 

ppp-new branch, based from latest pppd git master and various paths, use:

    if (ho->hisaddr == 0 && !pcb->settings.noremoteip) {
        ho->hisaddr = htonl(0x0a404040);
        ppp_warn("Could not determine remote IP address: defaulting to %I",
             ho->hisaddr);
    }

Which seem a better approach than your suggested change against the current lwIP release.

Sylvain Rochet <gradator>
Group Member
Thu 11 Oct 2012 05:59:14 PM UTC, comment #1: 
Mark Lakata <lakata>
Thu 11 Oct 2012 05:54:23 PM UTC, original submission:  

The function ipcp_up() checks the HISADDR field is not zero, and aborts the PPP connection if it is.

This is an optional field and many 3G providers do not supply this field. There should be a compile time option to disable this check.

The suggested change is adding a compiler flag, such as PPP_HISADDR_WARNING


  if (ho->hisaddr == 0) {
#ifdef PPP_HISADDR_WARNING
    IPCPDEBUG(LOG_ERR, ("Warning: Remote IP address is 0\n"));
#else
    IPCPDEBUG(LOG_ERR, ("Could not determine remote IP address\n"));
    ipcp_close(f->unit, "Could not determine remote IP address");
    return;
#endif
  }

Mark Lakata <lakata>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Updated the item)
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by lakata (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-05-22 gradator StatusNone Fixed
        Open/ClosedOpen Closed
        Planned Release 1.5.0
    2013-01-14 goldsimon CategoryContrib PPP

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code