buglwIP - A Lightweight TCP/IP stack - Bugs: bug #37959, ip6_debug_print prints plen,...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #37959: ip6_debug_print prints plen, nexth, hoplim in wrong byte order

Submitted by:  Valery Ushakov <uwe>
Submitted on:  Wed 19 Dec 2012 03:36:25 PM UTC  
 
Category:  IPv6 Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  Ivan Delamer <idelamer>
Open/Closed:  Closed Planned Release:  None
lwIP version:  CVS Head

Wed 19 Dec 2012 11:39:05 PM UTC, comment #1: 

Good catch, ntohs() is not necessary, and seems to be there due to an ugly copy-paste error.

Will push a fix for this.

Thanks for reporting

PS: 'H' is for 'H'eader  ;-)

Ivan Delamer <idelamer>
Project MemberIn charge of this item.
Wed 19 Dec 2012 03:36:25 PM UTC, original submission:  

ip6_debug_print prints plen, netxh, hoplim with an extra ntohs, e.g. ntohs(IP6H_PLEN(ip6hdr)), etc - but IP6H_* macros already do ntohs() internally (as hinted by 'H'ost in their names).

Valery Ushakov <uwe>

 

Attached Files
file #27125:  ip6_debug_print.diff added by uwe (839B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by idelamer (Posted a comment)
  • -email is unavailable- added by uwe (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-12-19 idelamer StatusNone => Fixed
    2012-12-19 idelamer Assigned toNone => idelamer
        Open/ClosedOpen => Closed
    2012-12-19 uwe Attached File- => Added ip6_debug_print.diff, #27125

    Back to the top


    Powered by Savane 3.5