lwIP - A Lightweight TCP/IP stack - Bugs: bug #43235, Numerous compiler warnings in...
You are not allowed to post comments on this tracker with your current authentication level.
bug #43235: Numerous compiler warnings in ppp_new code
Submitter: | Simon Goldschmidt <goldsimon> | ||
Submitted: | Tue 16 Sep 2014 06:39:35 PM UTC | ||
Category: | PPP | Severity: | 1 - Wish |
Item Group: | Compiler Warning | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Sun 22 Feb 2015 09:10:38 PM UTC, comment #11: |
Simon Goldschmidt <goldsimon> |
Sun 22 Feb 2015 09:03:16 PM UTC, comment #10:
|
Sylvain Rochet <gradator> |
Sun 22 Feb 2015 06:41:14 PM UTC, comment #9:
|
Simon Goldschmidt <goldsimon> |
Thu 19 Feb 2015 01:09:18 PM UTC, comment #8: And could you try fixing C4028 ?, I don't see why your compiler is complaining. |
Sylvain Rochet <gradator> |
Thu 19 Feb 2015 01:00:59 PM UTC, comment #7: Could you try fixing C4310 ?
|
Sylvain Rochet <gradator> |
Thu 19 Feb 2015 12:41:39 PM UTC, comment #6: With VS2010, I get these:
|
Simon Goldschmidt <goldsimon> |
Wed 18 Feb 2015 10:46:50 PM UTC, comment #5: No more compiler warnings for me using GCC. |
Sylvain Rochet <gradator> |
Sun 12 Oct 2014 07:20:08 PM UTC, comment #4:
|
Sylvain Rochet <gradator> |
Tue 16 Sep 2014 07:53:01 PM UTC, comment #3: There also seem to be some lines using '#if XYZ' checking for non-existent preprocessor macros. This is non-standard (gcc should warn about it) and these macros should be predefined in opt.h or ppp.h. |
Simon Goldschmidt <goldsimon> |
Tue 16 Sep 2014 07:47:44 PM UTC, comment #2: Forget the last comment, I just saw that it's not meant to work ;-) |
Simon Goldschmidt <goldsimon> |
Tue 16 Sep 2014 07:38:44 PM UTC, comment #1: Update: ccp.h doesn't event compile as it uses 'bool' which is only available in C++, not in C. Am I doing something wrong here??? |
Simon Goldschmidt <goldsimon> |
Tue 16 Sep 2014 06:39:35 PM UTC, original submission:
I have to admit it's the first time I'm compiling the PPP code with the win32 project with PPP enabled, but I really get many warnings. Is the original code really in that bad shape? Are these our changes or are the warnings in the original code?
|
Simon Goldschmidt <goldsimon> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2015-02-22 | goldsimon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2015-02-22 | goldsimon | Status | None | In Progress | |
Assigned to | None | goldsimon | |||
2014-10-12 | gradator | Severity | 3 - Normal | 1 - Wish | |
2014-09-16 | goldsimon | Summary | Numerous compiler warnings and errors n ppp_new code | Numerous compiler warnings in ppp_new code | |
2014-09-16 | goldsimon | Summary | Numerous compiler warnings in ppp_new code | Numerous compiler warnings and errors n ppp_new code |
Powered by Savane 3.13-02a9.
Corresponding source code
In fact, a really expensive compiler just told me that this missing cast (unsigned to signed) could be unportable on some compilers as it doesn't follow the standard. They didn't say which compilers though...
About the memcpy thing: MEMCPY was memcpy until someone wanted to be able to override it. So it is still memcpy as long as you want it to be something else. And this should work out of the box.
I'll change the cc.h of the win32 port but other than that, we're OK now.
Thanks for your great work on PPP!