lwIP - A Lightweight TCP/IP stack - Bugs: bug #44565, PPPOS support in tcpip thread...
You are not allowed to post comments on this tracker with your current authentication level.
bug #44565: PPPOS support in tcpip thread breaks SLIP
Submitter: | Ivan Delamer <idelamer> | ||
Submitted: | Tue 17 Mar 2015 10:54:46 PM UTC | ||
Category: | PPP | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | idelamer |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Fri 20 Mar 2015 03:14:46 PM UTC, comment #24: |
Sylvain Rochet <gradator> |
Fri 20 Mar 2015 02:59:55 PM UTC, comment #23: I would make a note of the flag name change in release notes in case anyone is affected. And I agree with Simon, lets not break any existing ports by changing ethernet_input handling.
|
Ivan Delamer <idelamer> |
Fri 20 Mar 2015 08:53:52 AM UTC, comment #22: Hello Simon,
|
Sylvain Rochet <gradator> |
Fri 20 Mar 2015 07:28:49 AM UTC, comment #21:
|
Simon Goldschmidt <goldsimon> |
Thu 19 Mar 2015 08:56:19 PM UTC, comment #20: Patch rebased and applied. I am very happy with the outcome, this long lasting issue is solved for me in the cleanest way.
|
Sylvain Rochet <gradator> |
Thu 19 Mar 2015 09:00:31 AM UTC, comment #19: /* if pppos_input_free_current_packet() was called in the meanwhile (connect, listen, or free) */
|
Sylvain Rochet <gradator> |
Thu 19 Mar 2015 08:55:26 AM UTC, comment #18: I forget to add but of course I totally agree it is almost fully thread safe in interrupt context, being interrupt safe and being thread safe is not the same thing at all ! :-)
|
Sylvain Rochet <gradator> |
Thu 19 Mar 2015 08:50:14 AM UTC, comment #17:
|
Sylvain Rochet <gradator> |
Thu 19 Mar 2015 06:27:39 AM UTC, comment #16: Much better :-)
|
Simon Goldschmidt <goldsimon> |
Wed 18 Mar 2015 07:59:27 PM UTC, comment #15: I like it. I will probably do the same with 6LowPAN in the future. I wonder if we should do the same with Ethernet packets? |
Ivan Delamer <idelamer> |
Wed 18 Mar 2015 07:54:29 PM UTC, comment #14: Added patch which adds TCPIP_MSG_INPKT_PPPOS.
|
Sylvain Rochet <gradator> |
Wed 18 Mar 2015 05:44:00 PM UTC, comment #13: Hello Simon,
*
*/
|
Sylvain Rochet <gradator> |
Wed 18 Mar 2015 05:27:20 PM UTC, comment #12: And I don't want to sound rude here. I just like to discuss such a change.
|
Simon Goldschmidt <goldsimon> |
Wed 18 Mar 2015 05:25:40 PM UTC, comment #11:
|
Simon Goldschmidt <goldsimon> |
Wed 18 Mar 2015 05:16:43 PM UTC, comment #10:
|
Sylvain Rochet <gradator> |
Wed 18 Mar 2015 05:11:36 PM UTC, comment #9: Hello Simon,
|
Sylvain Rochet <gradator> |
Wed 18 Mar 2015 05:04:40 PM UTC, comment #8: Another option, for this and other cases is:
|
Ivan Delamer <idelamer> |
Wed 18 Mar 2015 04:59:22 PM UTC, comment #7:
|
Simon Goldschmidt <goldsimon> |
Wed 18 Mar 2015 04:53:26 PM UTC, comment #6: I did submit the fix, but I think it is better to add a PPP flag to the netif and trigger a special case. like for ethernet.
|
Ivan Delamer <idelamer> |
Wed 18 Mar 2015 04:44:44 PM UTC, comment #5: Hello,
|
Sylvain Rochet <gradator> |
Wed 18 Mar 2015 04:33:45 PM UTC, comment #4: Sorry for not taking part earlier, but in my opinion, misusing the input callback here is the bug, not breaking SLIP.
|
Simon Goldschmidt <goldsimon> |
Wed 18 Mar 2015 04:05:32 PM UTC, comment #3: Yes, I think the input function is a bit historical/legacy, but useful if yo have protocols other than ip/ip6, such as ARP or in your case with PPP.
|
Ivan Delamer <idelamer> |
Tue 17 Mar 2015 11:06:40 PM UTC, comment #2: Hello Ivan,
|
Sylvain Rochet <gradator> |
Tue 17 Mar 2015 10:58:03 PM UTC, comment #1: I tested adding this line:
|
Ivan Delamer <idelamer> |
Tue 17 Mar 2015 10:54:46 PM UTC, original submission:
PPPOS uses the tcpip thread to process incoming packets. This code was added to tcpip_thread():
|
Ivan Delamer <idelamer> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2015-03-20 | gradator | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2015-03-18 | gradator | Status | Fixed | In Progress | |
Open/Closed | Closed | Open | |||
2015-03-18 | gradator | Attached File | - | Added 0001-PPP-PPPoS-improved-tcpip-input-path.patch, #33392 | |
2015-03-18 | idelamer | Status | Ready For Test | Fixed | |
Assigned to | None | idelamer | |||
Open/Closed | Open | Closed | |||
2015-03-17 | idelamer | Status | None | Ready For Test |
Powered by Savane 3.13-02a9.
Corresponding source code
Yes, this is already in the PPP documentation:
http://git.savannah.gnu.org/cgit/lwip.git/tree/doc/ppp.txt#n391
In order to not duplicate documentation, we should just put a pointer in the release notes about the "Upgrading from lwIP <= 1.4.x to lwIP >= 1.5.x" chapter in the PPP documentation.