lwIP - A Lightweight TCP/IP stack - Bugs: bug #45029, Several macros use ip6_2_ip()...
You are not allowed to post comments on this tracker with your current authentication level.
bug #45029: Several macros use ip6_2_ip() without supplying a storage address
Submitter: | Ivan Delamer <idelamer> | ||
Submitted: | Tue 05 May 2015 06:16:38 PM UTC | ||
Category: | IPv6 | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Tue 25 Aug 2015 05:35:25 AM UTC, comment #8: |
Simon Goldschmidt <goldsimon> |
Tue 12 May 2015 05:31:31 PM UTC, comment #7: I think API will stay the same. As long as we use the API instead of accessing netif-> fields directly, we'll be fine.
|
Ivan Delamer <idelamer> |
Mon 11 May 2015 07:51:06 PM UTC, comment #6:
|
Simon Goldschmidt <goldsimon> |
Wed 06 May 2015 04:49:41 PM UTC, comment #5: I can now say that providing temporary storage addresses is becoming really annoying to work with.
|
Ivan Delamer <idelamer> |
Tue 05 May 2015 09:43:31 PM UTC, comment #4: Actually now I'm seeing that in some cases it is not cast directly (e.g. netconn_bind)
|
Ivan Delamer <idelamer> |
Tue 05 May 2015 07:02:13 PM UTC, comment #3: Hmm, good point. OTOH, I also thought about making the netif addresses ip_addr_t, just to be able to use them as parameters to all the functions taking ip_addr_t pointers...
|
Simon Goldschmidt <goldsimon> |
Tue 05 May 2015 06:27:25 PM UTC, comment #2: Another option is to keep the like they were originally. Here is what I mean:
|
Ivan Delamer <idelamer> |
Tue 05 May 2015 06:23:00 PM UTC, comment #1: Yep, seems like I have forgotten to remove them in api.h. I already removed some of the "overloaded" IPv6 function-like macros, e.g. in udp. |
Simon Goldschmidt <goldsimon> |
Tue 05 May 2015 06:16:38 PM UTC, original submission:
With the new ip_addr_t with type field, there are times where we must convert a version-specific address to a generic address.
|
Ivan Delamer <idelamer> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2015-08-25 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed |
Powered by Savane 3.13-02a9.
Corresponding source code
Fixed by removing the defines. Plus I'll change the netif addresses to ip_addr_t.
Also, I've added bug #45818 (API functions should check if type of ip_addr_t parameter matches the pcb type).