buglwIP - A Lightweight TCP/IP stack - Bugs: bug #45322, ICMP echo reply checksum wrong on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45322: ICMP echo reply checksum wrong on NULL Bytes payload

Submitter:  TabascoEye <tabascoeye>
Submitted:  Mon 15 Jun 2015 09:23:12 AM UTC
   
 
Category:  IPv4 Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Mon 15 Jun 2015 01:58:00 PM UTC, comment #1: 

I cherry picked 32c32d8e26 in your github repository, removed the childish ¯\_(ツ)_/¯ from authorship and reworded the commit message.

Sylvain

Sylvain Rochet <gradator>
Group Member
Mon 15 Jun 2015 09:23:12 AM UTC, original submission:  

When a client sends an ICMP echo request with ID 0, Sequence 0 and either no data or any amount of 0x00 Bytes as data, the checksum in the reply by LWIP is wrong (off-by-one).

Expected checksum is 0xffff in that case, observed is 0x0000.
So the client does not see that reply as valid and determines the LWIP device as unreachable.

Attached patch fixes the off-by-one error when checksum should be 0xffff

TabascoEye <tabascoeye>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #34223:  ping_reply_to_0_bytes_payload.diff added by tabascoeye (553B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by tabascoeye (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-06-15 gradator StatusNone Fixed
        Open/ClosedOpen Closed
    2015-06-15 tabascoeye Attached File- Added ping_reply_to_0_bytes_payload.diff, #34223

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code