buglwIP - A Lightweight TCP/IP stack - Bugs: bug #45708, LWIP_ASSERT in api_msg.c, function...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45708: LWIP_ASSERT in api_msg.c, function err_tcp, seems wrong.

Submitted by:  Paul Szego <pszego>
Submitted on:  Thu 06 Aug 2015 05:17:12 PM UTC  
 
Category:  TCP Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  Simon Goldschmidt <goldsimon>
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Tue 18 Aug 2015 06:29:53 PM UTC, comment #1: 

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 06 Aug 2015 05:17:12 PM UTC, original submission:  

The LWIP_ASSERT at line 418, in function err_tcp() doesn't seem correct:

      LWIP_ASSERT("inavlid op_completed_sem", op_completed_sem != SYS_SEM_NULL);

The declaration of op_completed_sem:

    sys_sem_t* op_completed_sem

so it's a pointer to a sys_sem_t, whereas SYS_SEM_NULL is just a plain sys_sem_t. Perhaps replace that assert with this:

      LWIP_ASSERT("inavlid op_completed_sem", *op_completed_sem != SYS_SEM_NULL);

Paul Szego <pszego>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by pszego (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-08-18 goldsimon StatusNone => Fixed
        Assigned toNone => goldsimon
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5