lwIP - A Lightweight TCP/IP stack - Bugs: bug #45829, ipX_to_ip() function does not work...
You are not allowed to post comments on this tracker with your current authentication level.
bug #45829: ipX_to_ip() function does not work when just one IP version supported
Submitter: | Erik Ekman <yarrick> | ||
Submitted: | Wed 26 Aug 2015 09:05:48 AM UTC | ||
Category: | IPv4 | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Works For Me |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Thu 27 Aug 2015 07:43:29 PM UTC, comment #6: |
Simon Goldschmidt <goldsimon> |
Wed 26 Aug 2015 08:31:21 PM UTC, comment #5: Ok, I see.
|
Erik Ekman <yarrick> |
Wed 26 Aug 2015 06:43:22 PM UTC, comment #4: The real question is whether these macros/functions should be exported to applications. Portable applications should use ip_addr_t anyway, not ip4_addr_t, and I'd like to enforce this by not exporing ipX_2_ip() to application code. Only I haven't found a decent way to do this, yet. |
Simon Goldschmidt <goldsimon> |
Wed 26 Aug 2015 06:41:16 PM UTC, comment #3: I don't think I get the point of this patch. The code you wrote in the OP is wrong. You should not ignore the return value. It should rather pass the return value of ipX_2_ip() to udp_sendto_if(). |
Simon Goldschmidt <goldsimon> |
Wed 26 Aug 2015 12:18:57 PM UTC, comment #2: v3 of patch
|
Erik Ekman <yarrick> |
Wed 26 Aug 2015 09:16:43 AM UTC, comment #1: v2 patch that uses the right copy macro.
|
Erik Ekman <yarrick> |
Wed 26 Aug 2015 09:05:48 AM UTC, original submission:
When both IP versions are supported, ip4_to_ip()/ip6_to_ip() converts the IP version-specific first argument to an IP version-independent type given as the second argument.
|
Erik Ekman <yarrick> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2015-08-27 | goldsimon | Assigned to | None | goldsimon | |
Open/Closed | Open | Closed | |||
2015-08-26 | goldsimon | Status | None | Works For Me | |
2015-08-26 | yarrick | Attached File | - | Added 0001-Make-ipX_to_ip-work-when-just-one-IP-version-v3.patch, #34737 | |
2015-08-26 | yarrick | Attached File | - | Added 0001-Make-ipX_to_ip-work-when-just-one-IP-version-v2.patch, #34735 | |
2015-08-26 | yarrick | Attached File | - | Added 0001-Make-ipX_to_ip-work-when-just-one-IP-version-support.patch, #34733 |
Powered by Savane 3.13-f8d8.
Corresponding source code
The question would be how can we ensure the 2nd argumen isn't used (like in your OP code)?
Anyway, I don't think it's a bug... -> closed