lwIP - A Lightweight TCP/IP stack - Bugs: bug #47361, Remove ppp_init()
You are not allowed to post comments on this tracker with your current authentication level.
bug #47361: Remove ppp_init()
Submitter: | Simon Goldschmidt <goldsimon> | ||
Submitted: | Tue 08 Mar 2016 08:11:47 AM UTC | ||
Category: | PPP | Severity: | 3 - Normal |
Item Group: | None | Status: | Fixed |
Privacy: | Public | Assigned to: | gradator |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Thu 21 Apr 2016 09:37:47 PM UTC, comment #2: |
Sylvain Rochet <gradator> |
Wed 16 Mar 2016 03:35:38 PM UTC, comment #1: Sylvain, any input on this? |
Simon Goldschmidt <goldsimon> |
Tue 08 Mar 2016 08:11:47 AM UTC, original submission:
ppp_init() does not seem to be used. The only thing it does is calling magic_init(), which is not required because it its called again later from ppp_input().
|
Simon Goldschmidt <goldsimon> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-04-21 | gradator | Category | None | PPP | |
Status | None | Fixed | |||
Assigned to | None | gradator | |||
Open/Closed | Open | Closed |
Powered by Savane 3.13-caa5.
Corresponding source code
I agree ppp_init is not really useful, I already thought about removing this one previously. Removed.
The point is, I'm not confident regarding cryptography (only a very few developers around the world actually are), so I prefer avoid breaking randomness just for the sake of removing a function call :-)
At least, currently, even with very bad randomness gathered from the user LWIP_RAND function (or even no randomness at all) we still have a properly randomized pool in PPP.