buglwIP - A Lightweight TCP/IP stack - Bugs: bug #47447, UDP: use netif addr as source for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #47447: UDP: use netif addr as source for multicast bound sockets

Submitter:  Joel Cunningham <jcunningham>
Submitted:  Thu 17 Mar 2016 07:46:45 PM UTC
   
 
Category:  UDP Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  jcunningham
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Mon 18 Apr 2016 08:42:16 PM UTC, comment #3: 

Great, patch submitted in 8ac1b4825af1439601962d277c65e61bdc3929d4

If someone needs broadcast support, it can be added later

Joel Cunningham <jcunningham>
Group Member
Mon 18 Apr 2016 06:19:24 PM UTC, comment #2: 

Sorry for the late response.
Yes, the check for multicast looks OK to me. I wouldn't really bother for broadcas, though...

Simon Goldschmidt <goldsimon>
Group administrator
Wed 13 Apr 2016 08:58:05 PM UTC, comment #1: 

Anyone have a chance to look at this bug yet?

It seems pretty straight forward to me, only question is do we want to add additional handling for sockets bound to global/subnet broadcast addresses

Joel Cunningham <jcunningham>
Group Member
Thu 17 Mar 2016 07:46:45 PM UTC, original submission:  

Sockets bound to multicast addresses fail to transmit in udp_sendto_if() because pcb->local_ip doesn't match the IP address of the selected output netif.

The attached patch handles this case similarly to the INADDR_ANY case by using the netif address as the source IP address.

Additionally, I think this problem also applies to sockets bound to global broadcast and subnet broadcast addresses, but I don't have an example on hand to test with

Joel Cunningham <jcunningham>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jcunningham (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-04-18 jcunningham StatusNone Fixed
        Assigned toNone jcunningham
        Open/ClosedOpen Closed
    2016-03-17 jcunningham Attached File- Added 0001-udp-use-netif-addr-as-src-for-multicast-sockets.patch, #36676

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code