buglwIP - A Lightweight TCP/IP stack - Bugs: bug #48688, pppoe_connect() may return wrong...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #48688: pppoe_connect() may return wrong error codes

Submitter:  Dirk Ziegelmeier <dziegel>
Submitted:  Wed 03 Aug 2016 11:20:38 AM UTC
   
 
Category:  PPP Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  gradator
Open/Closed:  Closed Planned Release:  2.0.0
lwIP version:  git head

Thu 04 Aug 2016 10:18:11 PM UTC, comment #2: 

Fixed by removing the condition which returned EBUSY, it is always false.

About 0 used instead of ERR_OK, I failed to see one of them in the whole PPPoE code on features that are enabled.

Sylvain Rochet <gradator>
Group Member
Wed 03 Aug 2016 06:44:08 PM UTC, comment #1: 

A correct replacement for EBUSY would probably be "ERR_ALREADY".

  1. is not a literal err_t, but ERR_OK is 0, so this is more of a cosmetic change...
Simon Goldschmidt <goldsimon>
Group administrator
Wed 03 Aug 2016 11:20:38 AM UTC, original submission:  

- may return EBUSY which is not an err_t
- may return 0 which is not an err_t

Dirk Ziegelmeier <dziegel>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by dziegel (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-08-07 gradator Open/ClosedOpen Closed
    2016-08-04 gradator StatusNone Fixed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code