buglwIP - A Lightweight TCP/IP stack - Bugs: bug #49895, Incorrect configuration detection...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #49895: Incorrect configuration detection in lwip/dns.h

Submitter:  Thomas Mueller <tmu>
Submitted:  Tue 20 Dec 2016 11:47:10 AM UTC
   
 
Category:  DNS Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  2.0.1
lwIP version:  2.0.0

Tue 20 Dec 2016 01:21:48 PM UTC, comment #1: 

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Tue 20 Dec 2016 11:47:10 AM UTC, original submission:  

src/include/lwip/dns.h uses "#if defined" to test for LWIP_IPV4
configuration instead of "#if".


diff --git a/src/include/lwip/dns.h b/src/include/lwip/dns.h
index 3753a53a..2d147afa 100644
--- a/src/include/lwip/dns.h
+++ b/src/include/lwip/dns.h
@@ -61,7 +61,7 @@ extern "C" {
 #ifndef LWIP_DNS_ADDRTYPE_DEFAULT
 #define LWIP_DNS_ADDRTYPE_DEFAULT   LWIP_DNS_ADDRTYPE_IPV4_IPV6
 #endif
-#elif defined(LWIP_IPV4)
+#elif LWIP_IPV4
 #define LWIP_DNS_ADDRTYPE_DEFAULT   LWIP_DNS_ADDRTYPE_IPV4
 #else
 #define LWIP_DNS_ADDRTYPE_DEFAULT   LWIP_DNS_ADDRTYPE_IPV6


Thomas Mueller <tmu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by tmu (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-12-20 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.0.1

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code