buglwIP - A Lightweight TCP/IP stack - Bugs: bug #50042, ETHADDR16_COPY from...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #50042: ETHADDR16_COPY from netif->hwaddr

Submitter:  Daniel Elstner <danielk>
Submitted:  Thu 12 Jan 2017 09:20:21 PM UTC
   
 
Category:  ARP Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  2.0.0

Fri 13 Jan 2017 07:19:15 AM UTC, comment #2: 

Thanks for reporting!

Dirk Ziegelmeier <dziegel>
Group administrator
Fri 13 Jan 2017 02:18:48 AM UTC, comment #1: 

Addendum: ETHADDR32_COPY(&ethhdr->dest, dst) is likewise incorrect for the destination if ETH_PAD_SIZE is not 0.

I wonder if these macros should just be dropped. No idea if anyone actually makes use of the option to customize those.

Daniel Elstner <danielk>
Thu 12 Jan 2017 09:20:21 PM UTC, original submission:  

ETHADDR16_COPY is supposed to work with 16-bit aligned source and destination, but etharp_input() uses the macro with source netif->hwaddr, which is not 16-bit aligned.

struct netif::hwaddr could easily be made 16-bit aligned by re-arranging the fields surrounding it. Alternatively, etharp_input() should not use ETHADDR16_COPY() in this case.

Daniel Elstner <danielk>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dziegel (Updated the item)
  • -email is unavailable- added by danielk (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-01-13 dziegel StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code