buglwIP - A Lightweight TCP/IP stack - Bugs: bug #50162, Minor bug in errno.h

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #50162: Minor bug in errno.h

Submitted by:  Dag Midling Larsen <dagml>
Submitted on:  Fri 27 Jan 2017 08:00:09 AM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Wont Fix
Privacy:  Public Assigned to:  Dirk Ziegelmeier <dziegel>
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Fri 03 Mar 2017 07:10:23 AM UTC, comment #5: 

I agree. It's not that important after all.

Dirk Ziegelmeier <dziegel>
Project AdministratorIn charge of this item.
Thu 02 Mar 2017 06:55:38 PM UTC, comment #4: 

Having #ifdef here instead of #if is not ideal, but unless we find a way not to break existing ports & applications, I'd say leave it as it is...

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 02 Feb 2017 08:10:23 PM UTC, comment #3: 

Just to clarify: up to now, LWIP_PROVIDE_ERRNO is not "0 or 1" but "defined or undefined". As such, this is not a real bug (i.e. compiling fails) but just bad style because we have all other defines set to "0 or 1" but never undefined.

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 02 Feb 2017 07:43:38 AM UTC, comment #2: 

Changing this breaks existing ports. Postponed to 2.1.0

Dirk Ziegelmeier <dziegel>
Project AdministratorIn charge of this item.
Fri 27 Jan 2017 08:09:42 AM UTC, comment #1: 

Thanks for reporting!

Dirk Ziegelmeier <dziegel>
Project AdministratorIn charge of this item.
Fri 27 Jan 2017 08:00:09 AM UTC, original submission:  

Currently in errno.h line 46:

#ifdef LWIP_PROVIDE_ERRNO

Should be:

#if LWIP_PROVIDE_ERRNO

Since this is an option that could be 0 or 1.

Dag Midling Larsen <dagml>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by dagml (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-03-03 dziegel StatusPostponed => Wont Fix
        Open/ClosedOpen => Closed
    2017-02-02 dziegel StatusFixed => Postponed
        Assigned toNone => dziegel
        Open/ClosedClosed => Open
    2017-01-27 dziegel StatusNone => Fixed
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5