buglwIP - A Lightweight TCP/IP stack - Bugs: bug #50220, mld6_leavegroup does not send...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #50220: mld6_leavegroup does not send ICMP6_TYPE_MLD, even if last reporter

Submitted by:  Luc Revardel <lrevardel>
Submitted on:  Fri 03 Feb 2017 02:14:14 PM UTC  
 
Category:  IPv6 Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  Simon Goldschmidt <goldsimon>
Open/Closed:  Closed Planned Release:  None
lwIP version:  2.0.0

Wed 08 Feb 2017 09:31:22 PM UTC, comment #4: 

Pushed your patch in the hope that its external behaviour is correct (I could only review it in terms of lwip internal usage and from here, it is definitively fixing things!)

Thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 08 Feb 2017 08:59:12 PM UTC, comment #3: 

Ignore the last comment, Bob just restored the file :-)

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 08 Feb 2017 08:16:16 PM UTC, comment #2: 

Luc, unfortunately I cannot download the file you attached (it says the file can't be found).

Would you mind uploading it again? Thanks.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sun 05 Feb 2017 11:14:53 AM UTC, comment #1: 

May I ask you to provide a patch? Since you seem to have fixed it and you have tested it it would be great to have a working fix.

Dirk Ziegelmeier <dziegel>
Project Administrator
Fri 03 Feb 2017 02:14:14 PM UTC, original submission:  

Issue:
mld6_leavegroup() should generate an ICMP6 packet (ICMP6_TYPE_MLD) when the host is the last one that reported ICMP6_TYPE_MLR for the specified group.
This packet is never sent, even when the host is the last reporter.

Root cause:
group->last_reporter_flag is never set to one.

Possible fix:
As done for IGMP, this flag could be set to one in mld6_send(), when the sent packet is ICMP6_TYPE_MLR.

Tested version: STABLE-2_0_0_RC2

Behavior observed while attempting a group leave on FF15::1, after successful group add and no other host on the network.

Luc Revardel <lrevardel>

 

Attached Files
file #39681:  mld6-leave.patch added by lrevardel (626B - application/octet-stream - Patch file ("git diff" output) mld6-leave.patch provided. Tested with a unique group listener.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by lrevardel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-02-08 goldsimon StatusNone => Fixed
        Assigned toNone => goldsimon
        Open/ClosedOpen => Closed
    2017-02-06 lrevardel Attached File- => Added mld6-leave.patch, #39681

    Back to the top


    Powered by Savane 3.5