lwIP - A Lightweight TCP/IP stack - Bugs: bug #51154, ABC (Appropriate Byte Counting)...
You are not allowed to post comments on this tracker with your current authentication level.
bug #51154: ABC (Appropriate Byte Counting) fails to work with TCP_WND set to maximum.
Submitter: | Tim Cussins <tcussins> | ||
Submitted: | Thu 01 Jun 2017 10:09:00 AM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | jcunningham |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Wed 14 Jun 2017 07:42:31 PM UTC, comment #13: |
Simon Goldschmidt <goldsimon> |
Fri 02 Jun 2017 08:55:22 PM UTC, comment #12: Patch committed in 3eaf976152d781a195caa80cf1e1ed34de631c95. This fixes the introduced regression in ABC changes
|
Joel Cunningham <jcunningham> |
Fri 02 Jun 2017 07:25:03 PM UTC, comment #11:
|
Simon Goldschmidt <goldsimon> |
Fri 02 Jun 2017 06:11:53 PM UTC, comment #10: Looks good I guess? |
Simon Goldschmidt <goldsimon> |
Fri 02 Jun 2017 08:53:59 AM UTC, comment #9: Hi Joel,
|
Tim Cussins <tcussins> |
Thu 01 Jun 2017 08:51:34 PM UTC, comment #8: Simon,
|
Joel Cunningham <jcunningham> |
Thu 01 Jun 2017 07:42:08 PM UTC, comment #7: Good catch. However, is this really correct? Shouldn't we stop at "TCP_WND" instead of "(tcpwnd_size_t)-1"? |
Simon Goldschmidt <goldsimon> |
Thu 01 Jun 2017 05:44:12 PM UTC, comment #6: I was able to reproduce the issue, there is integer promotion happening in the inequality that checks for rollover, meaning the check doesn't work.
|
Joel Cunningham <jcunningham> |
Thu 01 Jun 2017 05:27:50 PM UTC, comment #5: Could "snd_buf = 0" be the problem?
|
Simon Goldschmidt <goldsimon> |
Thu 01 Jun 2017 03:54:28 PM UTC, comment #4: Hi Joel,
|
Tim Cussins <tcussins> |
Thu 01 Jun 2017 02:52:30 PM UTC, comment #3: If you could also report these pcb values in the stuck state:
|
Joel Cunningham <jcunningham> |
Thu 01 Jun 2017 02:25:00 PM UTC, comment #2: Tim,
|
Joel Cunningham <jcunningham> |
Thu 01 Jun 2017 10:11:52 AM UTC, comment #1: Typo alert! That sentence should read:
|
Tim Cussins <tcussins> |
Thu 01 Jun 2017 10:09:00 AM UTC, original submission:
Hi,
|
Tim Cussins <tcussins> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-06-14 | goldsimon | Open/Closed | Open | Closed | |
2017-06-02 | jcunningham | Status | None | Fixed | |
2017-06-01 | jcunningham | Attached File | - | Added 0001-tcp-fix-cwnd-rollover-introduced-by-ABC.patch, #40837 | |
2017-06-01 | jcunningham | Assigned to | None | jcunningham |
Powered by Savane 3.13-02a9.
Corresponding source code
Joel, thinking it through, I think it's better to leave it the way it is. The result should be correct and I feel better using TCP_SND_BUF as a limitation on write only instead of having a side effect on the actual internal TCP implementation.
-> Closed