buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51230, Fix comment line

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51230: Fix comment line

Submitter:  Andrey Vinogradov <andreyvinogradov>
Submitted:  Tue 13 Jun 2017 11:48:26 AM UTC
   
 
Category:  apps Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Tue 13 Jun 2017 07:15:06 PM UTC, comment #1: 

Fixed, thanks for reporting.

> BTW, there is the best place to put declaration of this function?


I've changed httpd.c to include LWIP_HOOK_FILENAME, since this is the best place/file to declare such functions.

Simon Goldschmidt <goldsimon>
Group administrator
Tue 13 Jun 2017 11:48:26 AM UTC, original submission:  

src/include/lwip/apps/httpd_opts.h, line 274:
The function have this signature: u16_t fn(struct tcp_pcb* pcb);

The function should have the following signature:
u16_t fn(struct altcp_pcb* pcb);


BTW, there is the best place to put declaration of this function? I'm corrently placed it's declaration right in httpd.c file, but it's no good. If I place it in lwipopts.h compiler says that it doesn't know altcp_pcb structure and some other things.



Andrey Vinogradov <andreyvinogradov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by andreyvinogradov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-06-13 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code