buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51519, Clarify that sys_arch_protect()...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51519: Clarify that sys_arch_protect() always has a matching unprotect.

Submitter:  Douglas <ourairquality>
Submitted:  Thu 20 Jul 2017 12:34:05 PM UTC
   
 
Category:  Documentation Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Thu 20 Jul 2017 07:24:23 PM UTC, comment #1: 

Pushed, thanks for the patch. I really appreciate having someone with a somewhat outside view helping on the docs :-)

Simon Goldschmidt <goldsimon>
Group administrator
Thu 20 Jul 2017 12:34:05 PM UTC, original submission:  

The current documentation specifies sys_arch_unprotect() as resetting "the critical region protection to the value specified by pval". Such usage would not be compatible with implementations using a nesting counter, nor with many recursive mutex implementations, both of which require matching protect and unprotect operations.

Practically the current code seems to match protect and unprotect operations, so this is basically a warning that some implementations would break if there were not a matching unprotect for each protect operation. Also a warning that lwip code should not use the value returned by sys_arch_unprotect() except to pass it along.

Douglas <ourairquality>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by ourairquality (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-07-20 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2017-07-20 ourairquality Attached File- Added 0001-Clarify-that-sys_arch_protect-always-has-a-matching-.patch, #41264

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code