lwIP - A Lightweight TCP/IP stack - Bugs: bug #51538, Don't use signed types when...
You are not allowed to post comments on this tracker with your current authentication level.
bug #51538: Don't use signed types when overflow is expected
Submitter: | Daniel Elstner <danielk> | ||
Submitted: | Sat 22 Jul 2017 02:02:14 PM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | 2.1.0 |
lwIP version: | git head |
Fri 17 Nov 2017 08:39:42 PM UTC, comment #2: |
Simon Goldschmidt <goldsimon> |
Mon 24 Jul 2017 06:27:48 PM UTC, comment #1: Hmm, while the part about the standard is true, I'm not aware of a system where this doesn't work and as such, I didn't pay much attention.
|
Simon Goldschmidt <goldsimon> |
Sat 22 Jul 2017 02:02:14 PM UTC, original submission:
I just noticed that commit f3c860958fbea544e9e1e4222339a1373dcbf3b6 "-Wconversion (still far from finished) and other minor compilation fixes..." changes some types from unsigned to signed.
|
Daniel Elstner <danielk> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-11-17 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2017-11-17 | goldsimon | Planned Release | None | 2.1.0 |
Powered by Savane 3.13-02a9.
Corresponding source code
Obviously not, thanks for the talk ;-)
Reverting the 2 lines in question, I don't have access to a compiler telling me about -Wconversion right now, and it's not that pressing anyway: there are enough files left that don't compile with this setting...