buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51694, tcp_receive trimming the first...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51694: tcp_receive trimming the first edge might produce bogus pbuf chains

Submitter:  Simon Goldschmidt <goldsimon>
Submitted:  Tue 08 Aug 2017 09:06:57 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Wont Fix
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Mon 21 Aug 2017 08:36:15 PM UTC, comment #1: 

Fixing this might make the code more unreadable (the first pbuf must stay allocated as long as anyone accesses inseg.tcphdr), so given the frequency this happens, it's probably better left as is.

Simon Goldschmidt <goldsimon>
Group administrator
Tue 08 Aug 2017 09:06:57 PM UTC, original submission:  

The code seemed to be there forever: when trimming the first edge, first pbufs are set to "p->len = 0", which is kind of odd.

In addition to that, I'm not really sure the p->tot_len change is correct.

--> we need a unit test checking this :-/

Simon Goldschmidt <goldsimon>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-21 goldsimon StatusNone Wont Fix
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code