buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51765, pcb->dupacks > 3 logic added...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51765: pcb->dupacks > 3 logic added in 90873d6 not possible

Submitter:  Joel Cunningham <jcunningham>
Submitted:  Wed 16 Aug 2017 01:37:49 PM UTC
   
 
Category:  TCP Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Fri 25 Aug 2017 07:17:42 PM UTC, comment #1: 

Right. Thanks for watching. The 'else' had to be removed:
call tcp_rexmit_fast() more than once on dupacks since the actual transmission is guarded by TF_INFR, not by pcb->dupacks

Simon Goldschmidt <goldsimon>
Group administrator
Wed 16 Aug 2017 01:37:49 PM UTC, original submission:  

The dupacks > 3 logic added in 90873d6 is not possible to reach because the preceding if takes the > 3 case:


if (pcb->dupacks > 3) {
 /* Inflate the congestion window, but not if it means that
     the value overflows. */
   if ((tcpwnd_size_t)(pcb->cwnd + pcb->mss) > pcb->cwnd) {
     pcb->cwnd = (tcpwnd_size_t)(pcb->cwnd + pcb->mss);
   }
} else if (pcb->dupacks >=3) {


Joel Cunningham <jcunningham>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jcunningham (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-25 goldsimon Item GroupNone Faulty Behaviour
        StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code