lwIP - A Lightweight TCP/IP stack - Bugs: bug #52113, recv callback: To free or not to...
You are not allowed to post comments on this tracker with your current authentication level.
bug #52113: recv callback: To free or not to free pbuf when returning ERR_ABRT?
Submitter: | Ambroz Bizjak <abizjak> | ||
Submitted: | Mon 25 Sep 2017 07:42:10 PM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Mon 16 Oct 2017 08:02:27 AM UTC, comment #2: |
Dirk Ziegelmeier <dziegel> |
Mon 25 Sep 2017 07:46:22 PM UTC, comment #1: This is indeed unclear. I guess noone ever really thought about this unclarity. However, given the applications around, I guess your solution is correct: most applications returning ERR_ABRT will call tcp_close() after evaluating the pbuf and then fall back to aborting, eventually. (I'm not sure if this is really needed any more though) |
Simon Goldschmidt <goldsimon> |
Mon 25 Sep 2017 07:42:10 PM UTC, original submission:
After a quick look at the code around the invocation of the TCP recv callback, I have come to believe one must free the pbuf if returning ERR_ABRT.
|
Ambroz Bizjak <abizjak> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-10-16 | dziegel | Status | None | Fixed | |
Open/Closed | Open | Closed |
Powered by Savane 3.13-d3ae.
Corresponding source code
Fixed the docs as you suggested. Thank you!