buglwIP - A Lightweight TCP/IP stack - Bugs: bug #52638, Make some global variables static...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #52638: Make some global variables static (httpd.c)

Submitted by:  Mike Kleshov <kleshov>
Submitted on:  Mon 11 Dec 2017 08:26:14 AM UTC  
 
Category:  apps Severity:  1 - Wish
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Mon 18 Dec 2017 07:01:57 PM UTC, comment #3: 

Pushed with some additional modifications.

Simon Goldschmidt <goldsimon>
Project Administrator
Mon 18 Dec 2017 06:53:18 AM UTC, comment #2: 

Sure thing

(file #42669)

Mike Kleshov <kleshov>
Project Member
Sun 17 Dec 2017 09:22:43 PM UTC, comment #1: 

I'm with you there. However, I think it would be a good idea to provide a patch that does this ;-)

Simon Goldschmidt <goldsimon>
Project Administrator
Mon 11 Dec 2017 08:26:14 AM UTC, original submission:  

Looking at httpd.c, I can see a few global variables. I think it would be a good idea to make them static to reduce global namespace pollution.

Mike Kleshov <kleshov>
Project Member

 

Attached Files
file #42669:  httpd-make-globals-static.patch added by kleshov (8KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by kleshov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-12-18 goldsimon StatusNone => Fixed
        Open/ClosedOpen => Closed
    2017-12-18 kleshov Attached File- => Added httpd-make-globals-static.patch, #42669
    2017-12-11 kleshov SummaryMake some global variables static => Make some global variables static (httpd.c)

    Back to the top


    Powered by Savane 3.5