buglwIP - A Lightweight TCP/IP stack - Bugs: bug #52692, tcp: handle pcb->snd_queuelen...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #52692: tcp: handle pcb->snd_queuelen and chained pbufs during segment split

Submitted by:  Joel Cunningham <jcunningham>
Submitted on:  Tue 19 Dec 2017 03:45:04 PM UTC  
 
Category:  TCP Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  Joel Cunningham <jcunningham>
Open/Closed:  Closed Planned Release:  2.1.0
lwIP version:  git head

Tue 02 Jan 2018 03:18:00 PM UTC, comment #3:

Submitted in 04b983b4f376697f04980b8d547fa4d03aa10600

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.
Sun 31 Dec 2017 01:42:33 PM UTC, comment #2:

Sorry, this is quite a busy time.

The patch looks good!

Simon Goldschmidt <goldsimon>
Project Administrator
Wed 27 Dec 2017 02:37:44 PM UTC, comment #1:

Ping! Anyone have a chance to take a look at my patch?

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.
Tue 19 Dec 2017 03:45:04 PM UTC, original submission:

Found another issue in tcp_split_unsent_seg() where a chained pbuf was not correctly updating pcb->snd_queuelen during trimming and snd_queuelen would desynchronize if pbuf_realloc() freed some of the chain

Also, use pbuf_clen() for adding the new remaining segment rather than ++. The new remaining segment should always be one pbuf due to the semantics of PBUF_RAM, but this follows the best practice of using pbuf_clen()

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jcunningham (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-01-02 jcunningham StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
    2018-01-02 goldsimon Planned ReleaseNone => 2.1.0
    2017-12-19 jcunningham Attached File- => Added 0001-tcp-handle-pcb-snd_queuelen-and-chained-pbufs-during.patch, #42683

    Back to the top


    Powered by Savane 3.4